Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[RateLimiter] bug #42194 fix: sliding window policy to use microtime - fix test#43688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
chalasr merged 1 commit intosymfony:5.4fromjlekowski:sliding-policy-microtime
Oct 26, 2021
Merged

[RateLimiter] bug #42194 fix: sliding window policy to use microtime - fix test#43688

chalasr merged 1 commit intosymfony:5.4fromjlekowski:sliding-policy-microtime
Oct 26, 2021

Conversation

@jlekowski
Copy link
Contributor

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#42194
LicenseMIT
Doc PRsymfony/symfony-docs#...

As pointed out in the comment#43677 (comment),RateLimitTest::testWaitUsesMicrotime() fails intermittently.
I have looked at allPHPUnit actions since the test was introduced and interestingly, the fails only occurred during7.2 test, and the time difference was always ~1.3s.

@jlekowski
Copy link
ContributorAuthor

@chalasr, this should make the test pass consistently.

@Nyholm,@wouterj - I appreciate it if you review this one too. Thank you.

Copy link
Member

@chalasrchalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you. The remaining failures are unrelated?

@jlekowski
Copy link
ContributorAuthor

jlekowski commentedOct 26, 2021•
edited
Loading

Thank you. The remaining failures are unrelated?

Yes, they are unrelated.

chalasr reacted with thumbs up emoji

@chalasr
Copy link
Member

Thank you@jlekowski.

@chalasrchalasr merged commit1c79d80 intosymfony:5.4Oct 26, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

[RateLimiter] SlidingWindow to use microtime() instead of time()

3 participants

@jlekowski@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp