Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] Add completion feature on translation:update command#43676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[FrameworkBundle] Add completion feature on translation:update command#43676
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedOct 23, 2021
Hey! To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done? Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review. Cheers! Carsonbot |
b60f4d0 to2186a20Comparecarsonbot commentedOct 23, 2021
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
src/Symfony/Bundle/FrameworkBundle/Tests/Command/TranslationUpdateCommandCompletionTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Bundle/FrameworkBundle/Command/TranslationUpdateCommand.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Bundle/FrameworkBundle/Command/TranslationUpdateCommand.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
bfd516f to7cfc2b8Comparestephenkhoo commentedOct 25, 2021
Added locale completion with will update again if there's other conclusion from#43644 (review) Otherwise, it seems this PR has achieved its goal? |
src/Symfony/Bundle/FrameworkBundle/Command/TranslationUpdateCommand.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
17aad65 to6cd50d7Comparesrc/Symfony/Bundle/FrameworkBundle/Command/TranslationUpdateCommand.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
…tion:extract (welcoMattic)This PR was merged into the 5.4 branch.Discussion----------[FrameworkBundle] Rename translation:update to translation:extract| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | no| New feature? | no| Deprecations? | yes| Tickets |Fix#41411| License | MIT| Doc PR |As we discussed in#41411, I've renamed `translation:update` to `translation:extract` which is a more accurate name.`translation:update` will trigger a deprecation alert until 6.0 where we could remove it completely. For now all the code of the command lives in TranslationExtractCommand.php file, and TranslationUpdateCommand call it.I think it should be merged after#43676.It's my first attempt to deprecate something in Symfony, let me know if I forgot something or if I did something wrong.Commits-------223f18e Rename translation:update to translation:extract
f0e1711 to2f301aeComparefabpot commentedOct 29, 2021
Thank you@stephenkhoo. |
Uh oh!
There was an error while loading.Please reload this page.
Adding completion for translation:update.
Test for
Locale completion still under discussion in#43644 (review)
Locale and bundle test still not complete