Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[FrameworkBundle] Add completion feature on translation:update command#43676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@stephenkhoo
Copy link
Contributor

@stephenkhoostephenkhoo commentedOct 23, 2021
edited
Loading

QA
Branch?5.4
Bug fix?no
New feature?yes
Deprecations?no
TicketsPart of#43594
LicenseMIT
Doc PR-

Adding completion for translation:update.

  • locale
  • bundle
  • --format
  • --domain
  • --sort

Test for

  • locale
  • bundle
  • --format
  • --domain
  • --sort

Locale completion still under discussion in#43644 (review)

Locale and bundle test still not complete

@carsonbot
Copy link

Hey!

To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done?

Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review.

Cheers!

Carsonbot

@stephenkhoostephenkhooforce-pushed thefeat/translation-update-autocomplete branch fromb60f4d0 to2186a20CompareOctober 23, 2021 11:57
@stephenkhoostephenkhoo marked this pull request as ready for reviewOctober 23, 2021 11:59
@carsonbotcarsonbot added this to the5.4 milestoneOct 23, 2021
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@stephenkhoostephenkhoo changed the titleAdd completion feature on translation:update command #43594[Translation] Add completion feature on translation:update commandOct 23, 2021
@carsonbotcarsonbot changed the title[Translation] Add completion feature on translation:update commandAdd completion feature on translation:update commandOct 23, 2021
@carsonbotcarsonbot changed the titleAdd completion feature on translation:update command[FrameworkBundle] Add completion feature on translation:update commandOct 24, 2021
@stephenkhoostephenkhooforce-pushed thefeat/translation-update-autocomplete branch frombfd516f to7cfc2b8CompareOctober 25, 2021 11:28
@stephenkhoo
Copy link
ContributorAuthor

Added locale completion withLocales::getLocales()

will update again if there's other conclusion from#43644 (review)

Otherwise, it seems this PR has achieved its goal?

@stephenkhoostephenkhooforce-pushed thefeat/translation-update-autocomplete branch 2 times, most recently from17aad65 to6cd50d7CompareOctober 26, 2021 03:53
fabpot added a commit that referenced this pull requestOct 28, 2021
…tion:extract (welcoMattic)This PR was merged into the 5.4 branch.Discussion----------[FrameworkBundle] Rename translation:update to translation:extract| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | no| Deprecations? | yes| Tickets       |Fix#41411| License       | MIT| Doc PR        |As we discussed in#41411, I've renamed `translation:update` to `translation:extract` which is a more accurate name.`translation:update` will trigger a deprecation alert until 6.0 where we could remove it completely. For now all the code of the command lives in TranslationExtractCommand.php file, and TranslationUpdateCommand call it.I think it should be merged after#43676.It's my first attempt to deprecate something in Symfony, let me know if I forgot something or if I did something wrong.Commits-------223f18e Rename translation:update to translation:extract
@fabpotfabpotforce-pushed thefeat/translation-update-autocomplete branch fromf0e1711 to2f301aeCompareOctober 29, 2021 14:49
@fabpot
Copy link
Member

Thank you@stephenkhoo.

@fabpotfabpot merged commit375a89a intosymfony:5.4Oct 29, 2021
This was referencedNov 5, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@GromNaNGromNaNGromNaN requested changes

@welcoMatticwelcoMatticwelcoMattic left review comments

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

6 participants

@stephenkhoo@carsonbot@fabpot@GromNaN@welcoMattic@derrabus

[8]ページ先頭

©2009-2025 Movatter.jp