Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Translation] Add completion feature on translation pull and push commands#43672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@welcoMattic
Copy link
Member

@welcoMatticwelcoMattic commentedOct 23, 2021•
edited
Loading

QA
Branch?5.4
Bug fix?no
New feature?yes
Deprecations?no
TicketsFix (partially)#43594
LicenseMIT
Doc PR

This PR adds completion for arguments and options ontranslation:pull andtranslation:push commands.

GromNaN and andrii-bodnar reacted with thumbs up emoji
@carsonbotcarsonbot added this to the5.4 milestoneOct 23, 2021
@welcoMatticwelcoMatticforce-pushed thefeat/trans-cmd-autocomplete branch 2 times, most recently from76001ce toa8352e0CompareOctober 25, 2021 15:40
@welcoMatticwelcoMatticforce-pushed thefeat/trans-cmd-autocomplete branch 3 times, most recently from4f21b99 tof43980eCompareOctober 25, 2021 16:09
@welcoMattic
Copy link
MemberAuthor

@GromNaN It's ready for review here

@welcoMatticwelcoMatticforce-pushed thefeat/trans-cmd-autocomplete branch fromf43980e tod5eb582CompareOctober 25, 2021 17:05
@welcoMatticwelcoMatticforce-pushed thefeat/trans-cmd-autocomplete branch 2 times, most recently from48879bc to08aa83dCompareOctober 26, 2021 07:48
@welcoMatticwelcoMatticforce-pushed thefeat/trans-cmd-autocomplete branch 2 times, most recently from6207cd1 to0cc8581CompareOctober 26, 2021 08:18
@fabpot
Copy link
Member

Can you skip the tests for older versions of Symfony? Like in#43731 for instance.

welcoMattic reacted with thumbs up emoji

@welcoMatticwelcoMatticforce-pushed thefeat/trans-cmd-autocomplete branch 2 times, most recently frome108eec tofa17c79CompareOctober 26, 2021 08:44
@welcoMattic
Copy link
MemberAuthor

welcoMattic commentedOct 26, 2021•
edited
Loading

The last failing test seems to be related to#43688
Rebased on 5.4, everything is green.

@fabpot
Copy link
Member

Thank you@welcoMattic.

welcoMattic reacted with thumbs up emoji

@fabpotfabpot merged commit3f0f0ce intosymfony:5.4Oct 29, 2021
@welcoMatticwelcoMattic deleted the feat/trans-cmd-autocomplete branchOctober 29, 2021 14:47
This was referencedNov 5, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof requested changes

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

4 participants

@welcoMattic@fabpot@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp