NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Fix logging of impersonator introduced in 5.3#43659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 0 commits intosymfony:5.3fromjohanwilfer:impersonator_logging_fix

Oct 23, 2021

Merged

Fix logging of impersonator introduced in 5.3#43659

fabpot merged 0 commits intosymfony:5.3fromjohanwilfer:impersonator_logging_fix

Oct 23, 2021

Conversation

Copy link

Contributor

johanwilfer commentedOct 22, 2021

Q	A
Branch?	5.3
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	no
License	MIT
Doc PR

This fixes logging of impersonator_username, if getUserIdentifier is implemented on the user provider that was introduced in 5.3

johanwilfer requested review fromchalasr andwouterj ascode owners

October 22, 2021 14:55

carsonbot added Status: Needs Review Bug labels

Oct 22, 2021

carsonbot added this to the5.3 milestone

Oct 22, 2021

Copy link

carsonbot commentedOct 22, 2021

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot