NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[VarDumper] Fix dumping twig templates found in exceptions#43655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:4.4fromevent15:ticket_27921_clean

Oct 25, 2021

Merged

[VarDumper] Fix dumping twig templates found in exceptions#43655

nicolas-grekas merged 1 commit intosymfony:4.4fromevent15:ticket_27921_clean

Oct 25, 2021

Conversation

Copy link

Contributor

event15 commentedOct 22, 2021

Fix forCannot instantiate abstract class on (...) inExceptionCaster in VarDumper.

Q	A
Branch?	4.4 (and olders?)
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix#27921
License	MIT

In this issue#27921 @nicolas-grekas said that this affects very old versions - even 2.8. I created a branch from 4.4 according to the CONTRIBBUTING guide.

carsonbot added Status: Needs Review Bug VarDumper labels

Oct 22, 2021

carsonbot added this to the4.4 milestone

Oct 22, 2021

event15 mentioned this pull request

Oct 22, 2021

[VarDumper] FixCannot instantiate abstract class on (...)#43652

Closed

stof reviewed

Oct 22, 2021

View reviewed changes

src/Symfony/Component/VarDumper/Caster/ExceptionCaster.php OutdatedShow resolvedHide resolved

Copy link

ContributorAuthor

event15 commentedOct 22, 2021•
edited
Loading

I noticed that appveyor reports a mismatch between$expectedDump in tests and what the Windows returns. This is a minor error, but still, the test on Windows is red. Should I looking for any better way to test this?

I don't quite understand the problem with failing tests on version 7.4 high-deps. There is a suggestion in the documentation that it may be BC.

On the other hand, I see that merged PRs are also failing this steps (for example:https://github.com/symfony/symfony/actions/runs/1367057090 was merged) - so I don't know what it depends on.

event15 requested a review fromstof

October 25, 2021 06:58

nicolas-grekas changed the title~~[VarDumper] FixCannot instantiate abstract class on (...) in `Exce…~~[VarDumper] Fix dumping twig templates found in exceptions

Oct 25, 2021