Movatterモバイル変換

carsonbot added this to the5.4 milestone

GromNaN mentioned this pull request

[Console] add suggestions for debug commands: firewall, form, messenger, router#43598

Merged

wouterj mentioned this pull request

[DX] Add completion to Symfony commands#43594

Closed

54 tasks

wouterj requested changes

Copy link

Member

wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

That was quick, thanks!

I have a question regarding@wouterj 's comment on the issue

Ignore my comment, I didn't know about this$userClasses property.

Also, the password is the first argument right now, should we swap it to be after user-class?

No, it's fine like this (autocompletion should support it this way).

Can you please also add tests? (see the other completion PRs for examples)

src/Symfony/Bundle/SecurityBundle/Command/UserPasswordEncoderCommand.php OutdatedShow resolvedHide resolved

src/Symfony/Component/PasswordHasher/Command/UserPasswordHashCommand.php OutdatedShow resolvedHide resolved

carsonbot added Status: Needs Work and removed Status: Needs Review labels

wouterj added Security and removed Console labels

carsonbot changed the title~~[Console] Add autocompletion for security commands~~[Security] Add autocompletion for security commands

94noni force-pushed theft-console-autocomplete-security branch 2 times, most recently fromca1e869 to534c766Compare

October 22, 2021 14:36

chalasr reviewed

src/Symfony/Bundle/SecurityBundle/Command/UserPasswordEncoderCommand.php OutdatedShow resolvedHide resolved

94noni force-pushed theft-console-autocomplete-security branch from534c766 tob8adddaCompare

October 22, 2021 14:46

94noni commented

src/Symfony/Component/PasswordHasher/Command/UserPasswordHashCommand.phpShow resolvedHide resolved

94noni force-pushed theft-console-autocomplete-security branch fromb8addda to5c0f762Compare

October 22, 2021 14:52

[Console] Add autocompletion for security commands

49f45a9

94noni force-pushed theft-console-autocomplete-security branch from5c0f762 to49f45a9Compare

October 22, 2021 15:22

wouterj approved these changes

carsonbot added Status: Reviewed and removed Status: Needs Work labels

wouterj requested changes

Copy link

Member

wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Wait, let's block this for a bit as we first need to handle the backslashes properly in the completion feature:#43598

carsonbot added Status: Needs Work and removed Status: Reviewed labels

chalasr approved these changes

Copy link

Member

chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Unlocked

carsonbot removed the Status: Needs Work label

carsonbot added the Status: Reviewed label

wouterj approved these changes

derrabus added PasswordHasher and removed Security labels

carsonbot changed the title~~[Security] Add autocompletion for security commands~~[PasswordHasher] Add autocompletion for security commands

fabpot approved these changes

Copy link

Member

fabpot commentedOct 29, 2021

Thank you@94noni.

fabpot merged commitc3522c4 intosymfony:5.4