NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Console] Add completion to messenger:setup-transports command#43640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:5.4fromTayfun74:feature/messenger-setup-transport-completion

Oct 22, 2021

Merged

[Console] Add completion to messenger:setup-transports command#43640

fabpot merged 1 commit intosymfony:5.4fromTayfun74:feature/messenger-setup-transport-completion

Oct 22, 2021

Conversation

Copy link

Contributor

Tayfun74 commentedOct 21, 2021

Q	A
Branch?	5.4
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets	#43594
License	MIT
Doc PR	no

Add completion for command messenger:setup-transports (transport)

Tayfun74 requested a review fromsroze as acode owner

October 21, 2021 19:09

carsonbot added Status: Needs Review Console Feature labels

Oct 21, 2021

carsonbot added this to the5.4 milestone

Oct 21, 2021

Copy link

carsonbot commentedOct 21, 2021

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

wouterj reviewed

Oct 21, 2021

View reviewed changes

Copy link

Member

wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi! Thank you for creating this PR.

I've left 2 minor suggestions on the code - other than that this looks ready to merge imho!

src/Symfony/Component/Messenger/Command/SetupTransportsCommand.php Outdated

Comment on lines 89 to 93

		if (!$input->mustSuggestArgumentValuesFor('transport')) {
		return;
		}

		$suggestions->suggestValues($this->transportNames);

Copy link

Member

wouterjOct 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	if (!$input->mustSuggestArgumentValuesFor('transport')) {
	return;
	}

	$suggestions->suggestValues($this->transportNames);
	if (!$input->mustSuggestArgumentValuesFor('transport')) {
	$suggestions->suggestValues($this->transportNames);

	return;
	}

While normally, we favor "early return" in the Symfony code base, I propose to not do that in thecomplete() methods. This way, we minimize the diff (and potential merge conflicts) when we add more completion suggestions to this method in a future version.