Movatterモバイル変換

Skip to content

symfony/symfonyPublic

NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Console] [Framework] Add completion to secrets:set and fix secrets:remove#43626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

fabpot merged 1 commit intosymfony:5.4fromGromNaN:completion/5.4-secrets

Oct 22, 2021

Merged

[Console] [Framework] Add completion to secrets:set and fix secrets:remove#43626

fabpot merged 1 commit intosymfony:5.4fromGromNaN:completion/5.4-secrets

Oct 22, 2021

Conversation

@GromNaN

Copy link

Member

GromNaN commentedOct 20, 2021•
edited
Loading

Q	A
Branch?	5.4
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets	#43594
License	MIT
Doc PR	no

Add completion for commandsecrets:set (name)
Fix completion for commandsecrets:remove when local vault is disabled and add tests.
Upgrade the required version ofsymfony/console since commands cannot implement an interface that does not exist in older versions[Console] Implementing bash completion in a forward-compatible way #43620

@carsonbot

carsonbot added Status: Needs Review Console Feature labels

@carsonbot

carsonbot added this to the5.4 milestone

@carsonbot

carsonbot changed the title~~[Console][Framework] Add completion to secrets:set and fix secrets:remove~~[Console] [Framework] Add completion to secrets:set and fix secrets:remove

stof

stof reviewed

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/Command/SecretsSetCommand.phpShow resolvedHide resolved

@GromNaN

GromNaN force-pushed thecompletion/5.4-secrets branch 2 times, most recently from8aa3fa3 to134e36eCompare

October 21, 2021 10:24

@GromNaN

Copy link

MemberAuthor

GromNaN commentedOct 21, 2021

Rebased on#43628.

wouterj

wouterj reviewed

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/Command/SecretsSetCommand.phpShow resolvedHide resolved

src/Symfony/Bundle/FrameworkBundle/Tests/Command/SecretsRemoveCommandTest.php OutdatedShow resolvedHide resolved

src/Symfony/Bundle/FrameworkBundle/Tests/Command/SecretsRemoveCommandTest.php OutdatedShow resolvedHide resolved

src/Symfony/Bundle/FrameworkBundle/Tests/Command/SecretsRemoveCommandTest.php OutdatedShow resolvedHide resolved

src/Symfony/Bundle/FrameworkBundle/Tests/Command/SecretsSetCommandTest.php OutdatedShow resolvedHide resolved

@GromNaN

Add completion to commands secrets:set and fix secrets:remove

6f74cd8

@GromNaN

GromNaN force-pushed thecompletion/5.4-secrets branch from134e36e to6f74cd8Compare

October 21, 2021 13:05

@wouterj

wouterj mentioned this pull request

[DX] Add completion to Symfony commands#43594

Closed

54 tasks

fabpot

fabpot approved these changes

View reviewed changes

@carsonbot

carsonbot added Status: Reviewed and removed Status: Needs Review labels

@fabpot

Copy link

Member

fabpot commentedOct 22, 2021

Thank you@GromNaN.

@fabpot

fabpot merged commit568947a intosymfony:5.4

@GromNaN

GromNaN deleted the completion/5.4-secrets branch

October 22, 2021 11:16

This was referencedNov 5, 2021

Release v5.4.0-BETA1#43937

Merged

Release v6.0.0-BETA1#43939

Merged

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Labels

Console Feature Status: Reviewed

5 participants

@GromNaN

@fabpot

@stof

@wouterj

@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp