Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Validator] Add CidrValidator to allow validation of CIDR notations#43593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@popsorin
Copy link
Contributor

@popsorinpopsorin commentedOct 19, 2021•
edited
Loading

QA
Branch?5.4
Bug fix?no
New feature?yes
Deprecations?no
TicketsFix#36526
LicenseMIT
Doc PRsymfony/symfony-docs#15974

This PR will add a CIDR Constraint Validator that will check if a string is a valid CIDR notation.

derrabus, Adambean, and ApostolaT reacted with thumbs up emojichr-hertel, ging-dev, ApostolaT, and sstok reacted with heart emoji
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@popsorinpopsorinforce-pushed thefeature/cidr-notation-constraint branch fromdd88623 tocd820ecCompareOctober 19, 2021 15:36
@popsorinpopsorinforce-pushed thefeature/cidr-notation-constraint branch fromcd820ec to58ccbaeCompareOctober 19, 2021 15:51
@popsorinpopsorinforce-pushed thefeature/cidr-notation-constraint branch 2 times, most recently fromd1ec95b to6b20977CompareOctober 20, 2021 13:18
@popsorinpopsorinforce-pushed thefeature/cidr-notation-constraint branch 2 times, most recently from027a59d to87339a4CompareOctober 20, 2021 17:32
Co-authored-by: Calin Bolea <calin.bolea@gmail.com>
@popsorinpopsorinforce-pushed thefeature/cidr-notation-constraint branch from87339a4 to488ff61CompareOctober 21, 2021 09:28
@popsorin
Copy link
ContributorAuthor

popsorin commentedOct 22, 2021•
edited
Loading

Hey,@stof could you please take a look at the changes requested by your code review ? Thanks!

@derrabus
Copy link
Member

Thank you@popsorin.

popsorin reacted with heart emoji

@derrabusderrabus merged commit0a41bda intosymfony:5.4Oct 25, 2021
@Adambean
Copy link

Thank you@popsorin, looking forward to trying this out later. :)

derrabus reacted with thumbs up emojipopsorin and CalinBolea reacted with heart emoji

nicolas-grekas added a commit that referenced this pull requestOct 25, 2021
This PR was merged into the 4.4 branch.Discussion----------[Validator] Add translations for CIDR constraint| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | N/A| License       | MIT| Doc PR        | N/AThis PR backports the translations added in#43593. Additionally, I have added a German translation.Commits-------8903f8f [Validator] Add translations for CIDR constraint
This was referencedNov 5, 2021
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull requestNov 6, 2021
…psorin)This PR was merged into the 5.4 branch.Discussion---------- [Validator] Add documentation for the Cidr ValidatorHello everyone!This is the documentation for the Cidr validator and constraint.PR:symfony/symfony#43593Please take a look and let me know if I need to change anything!Commits-------16de4a9  [Validator] Add documentation for the CidrValidator
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof approved these changes

@derrabusderrabusderrabus approved these changes

+1 more reviewer

@CalinBoleaCalinBoleaCalinBolea left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

[Validator] Constraints\IP: Accept value with a CIDR notation

6 participants

@popsorin@carsonbot@derrabus@Adambean@stof@CalinBolea
[8]ページ先頭
©2009-2025 Movatter.jp