Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Messenger] Autoconfigurable attributes#43588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Tobion merged 1 commit intosymfony:5.4fromalirezamirsepassi:messenger/attributes
Oct 25, 2021

Conversation

@alirezamirsepassi
Copy link
Contributor

@alirezamirsepassialirezamirsepassi commentedOct 19, 2021•
edited
Loading

QA
Branch?5.4
Bug fix?no
New feature?yes
Deprecations?no
TicketsFix#41106
LicenseMIT
Doc PRsymfony/symfony-docs#15990

@ro0NL
Copy link
Contributor

ref#41202 :)

@alirezamirsepassi
Copy link
ContributorAuthor

ref#41202 :)

Oh sorry, didn't see that! :)

I suppose#41202 PR could not be merged right away because of lacking test and configurable attributes since May 13.
I would really appreciate it if@nicolas-grekas and@fabpot could help here.

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM after some minor tweaks

@nicolas-grekas
Copy link
Member

Oh, please also add a changelog entry in the component

@nicolas-grekas
Copy link
Member

And can you please prepare a PR for the doc?

@Tobion
Copy link
Contributor

Thanks for your work on this new feature!

@TobionTobion merged commitc3e4bf9 intosymfony:5.4Oct 25, 2021
@Tobion
Copy link
Contributor

Tobion commentedOct 25, 2021•
edited
Loading

There was a test failure for low deps

Symfony\Component\Messenger\Tests\DependencyInjection\MessengerPassTest::testTaggedMessageHandler
Error: Call to undefined method Symfony\Component\DependencyInjection\ContainerBuilder::registerAttributeForAutoconfiguration()

that I've fixed by raising the DI dependency for messenger.

@Tobion
Copy link
Contributor

I have also opened#43705 as a follow-up.

@alirezamirsepassi
Copy link
ContributorAuthor

Great!
Thank you@Tobion

This was referencedNov 5, 2021
wouterj added a commit to symfony/symfony-docs that referenced this pull requestJan 19, 2022
…assi)This PR was merged into the 5.4 branch.Discussion----------[Messenger] Autoconfigurable attributes<!--If your pull request fixes a BUG, use the oldest maintained branch that containsthe bug (seehttps://symfony.com/releases for the list of maintained branches).If your pull request documents a NEW FEATURE, use the same Symfony branch wherethe feature was introduced (and `5.x` for features of unreleased versions).-->symfony/symfony#43588Commits-------7069075 [#15990] Minor changesfdd8b86 [Messenger] Autoconfigurable attributes
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@srozesrozeAwaiting requested review from sroze

+1 more reviewer

@TobionTobionTobion approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

[Messenger] Message attributes

5 participants

@alirezamirsepassi@ro0NL@nicolas-grekas@Tobion@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp