Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Messenger] fix: TypeError in PhpSerializer::encode()#43568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedOct 18, 2021
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
derrabus commentedOct 18, 2021
Can you provide a test that covers your change? |
dsech commentedOct 19, 2021
Fixed the code style and added a test, but not sure its naming is the best |
src/Symfony/Component/Messenger/Transport/Serialization/PhpSerializer.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Ensure a MessageDecodingFailedException is thrown when the string to be unserialized is an empty string.This happens because unserializing an empty string does not issue a PHP warning, and simply returns false.
fabpot commentedOct 20, 2021
Thank you@dsech. |
Messenger does not throw a
MessageDecodingFailedExceptionfor some messages that have invalid bodies when using the native PHP serialize/deserialize format.This happens because unserializing an empty string does not issue a PHP warning, and simply returns false.