Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Add a warning in WDT when using symfony/symfony#43526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar.html.twig OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar.html.twig OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
4b5451a tof7d4494Comparesrc/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar.html.twigShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
ro0NL commentedOct 15, 2021
Any reason to not add |
fabpot commentedOct 16, 2021
@ro0NL We will still tag the |
javiereguiluz commentedOct 16, 2021
I wouldn't mark the package as "abandoned" in Composer/Packagist, because many non-savvy users will understand it as if the entire Symfony project is abandoned. We should avoid that confusion and bad marketing for the project at all costs. |
chalasr commentedOct 16, 2021
@javiereguiluz Note that Packagist allows to provide a replacement for the abandoned package, which could be symfony/flex here. |
javiereguiluz commentedOct 16, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Yes, but that would be confusing too 😭 Has Symfony project renamed to Flex? Has it merged with a different project called Flex? The thing is that for many non-experts, symfony/symfony repois Symfony. |
…'s needed by toolbar.html.twig (weaverryan)This PR was merged into the 5.4 branch.Discussion----------[5.4][WebProfiler] Fixing missing full_stack variable that's needed by toolbar.html.twig| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets | None| License | MIT| Doc PR | Not neededThe combination of#43526 and then#41257 created an undefined variable. By adding the variable here, it will flow from `toolbar_js.html.twig` into `toolbar.html.twig`.Tested locally after reproducing the issue. Thanks to symfony/ux test suite for catching this :)Commits-------0e8b864 Fixing missing full_stack variable that's needed by toolbar.html.twig
Uh oh!
There was an error while loading.Please reload this page.
Even if using the
symfony/symfonypackage is still possible, it is highly discouraged. It comes with limitations that cannot be fixed (when you are using Mailer/Notifier/Messenger bridges for instance). It also makes the code slower for no good reasons and makes you download all possible Symfony packages even if you are not using them.This has been the case since 4.0, it's time to warn people that they should upgrade ASAP.
We are adding a warning as we will still be tagging
symfony/symfonyfor the next major versions as these tags help the maintainers.