Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add a warning in WDT when using symfony/symfony#43526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4fromfabpot:full-stack-is-obsolete
Oct 16, 2021

Conversation

@fabpot
Copy link
Member

@fabpotfabpot commentedOct 15, 2021
edited by nicolas-grekas
Loading

QA
Branch?5.4
Bug fix?no
New feature?yes
Deprecations?no
Ticketsn/a
LicenseMIT
Doc PRn/a

Even if using thesymfony/symfony package is still possible, it is highly discouraged. It comes with limitations that cannot be fixed (when you are using Mailer/Notifier/Messenger bridges for instance). It also makes the code slower for no good reasons and makes you download all possible Symfony packages even if you are not using them.

This has been the case since 4.0, it's time to warn people that they should upgrade ASAP.

We are adding a warning as we will still be taggingsymfony/symfony for the next major versions as these tags help the maintainers.

image

image

@fabpotfabpotforce-pushed thefull-stack-is-obsolete branch from4b5451a tof7d4494CompareOctober 15, 2021 13:14
@ro0NL
Copy link
Contributor

Any reason to not add"abandoned": true for symfony/symfony?

@fabpotfabpot merged commite2754fb intosymfony:5.4Oct 16, 2021
@fabpotfabpot deleted the full-stack-is-obsolete branchOctober 16, 2021 10:10
@fabpot
Copy link
MemberAuthor

@ro0NL We will still tag thesymfony/symfony repository for various reasons (mainly to help the core team and to be able to quickly see when a PR was merged on Github). I don't know if marking a package as abandoned would stop the tags to be propagated to Packagist. If not, then that's a good idea.

@javiereguiluz
Copy link
Member

I wouldn't mark the package as "abandoned" in Composer/Packagist, because many non-savvy users will understand it as if the entire Symfony project is abandoned. We should avoid that confusion and bad marketing for the project at all costs.

ro0NL, derrabus, and zmitic reacted with thumbs up emoji

@chalasr
Copy link
Member

@javiereguiluz Note that Packagist allows to provide a replacement for the abandoned package, which could be symfony/flex here.

ro0NL reacted with eyes emoji

@javiereguiluz
Copy link
Member

javiereguiluz commentedOct 16, 2021
edited
Loading

Yes, but that would be confusing too 😭 Has Symfony project renamed to Flex? Has it merged with a different project called Flex?

The thing is that for many non-experts, symfony/symfony repois Symfony.

derrabus and zmitic reacted with thumbs up emoji

fabpot added a commit that referenced this pull requestNov 3, 2021
…'s needed by toolbar.html.twig (weaverryan)This PR was merged into the 5.4 branch.Discussion----------[5.4][WebProfiler] Fixing missing full_stack variable that's needed by toolbar.html.twig| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | None| License       | MIT| Doc PR        | Not neededThe combination of#43526 and then#41257 created an undefined variable. By adding the variable here, it will flow from `toolbar_js.html.twig` into `toolbar.html.twig`.Tested locally after reproducing the issue. Thanks to symfony/ux test suite for catching this :)Commits-------0e8b864 Fixing missing full_stack variable that's needed by toolbar.html.twig
This was referencedNov 5, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

+1 more reviewer

@noniagriconomienoniagriconomienoniagriconomie left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

8 participants

@fabpot@ro0NL@javiereguiluz@chalasr@nicolas-grekas@stof@noniagriconomie@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp