Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Messenger] Fix Redis Transport when username is empty#43484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
chalasr merged 1 commit intosymfony:4.4fromvillfa:fix/43306
Oct 24, 2021
Merged

[Messenger] Fix Redis Transport when username is empty#43484

chalasr merged 1 commit intosymfony:4.4fromvillfa:fix/43306
Oct 24, 2021

Conversation

@villfa
Copy link
Contributor

@villfavillfa commentedOct 13, 2021•
edited
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#43306
LicenseMIT
Doc PRn/a

Checking the username and the password withisset is not enough. We also need to check they're not empty strings.
This fixes the BC break introduced by#43124.

See alsohttps://3v4l.org/iASnE

@carsonbot
Copy link

Hey!

To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done?

Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review.

Cheers!

Carsonbot

@villfavillfa marked this pull request as ready for reviewOctober 13, 2021 20:38
@villfavillfa requested a review fromsroze as acode ownerOctober 13, 2021 20:38
@carsonbotcarsonbot added this to the5.4 milestoneOct 13, 2021
@villfavillfa changed the base branch from5.4 to5.3October 13, 2021 20:43
@derrabus
Copy link
Member

I think, we need to fix this on 4.4 again.

@derrabusderrabus modified the milestones:5.4,4.4Oct 13, 2021
@villfavillfa changed the base branch from5.3 to4.4October 13, 2021 20:48
@villfavillfa changed the base branch from4.4 to5.3October 13, 2021 20:48
@villfavillfa changed the base branch from5.3 to4.4October 13, 2021 21:09
@villfa
Copy link
ContributorAuthor

@derrabus The PR is rebased onto 4.4.

derrabus reacted with thumbs up emoji

@chalasr
Copy link
Member

@villfa Thank you for the PR. Can you please force-push again to trigger the CI?

@derrabus
Copy link
Member

@chalasr I closed and reopened the PR and that did the trick apparently.

chalasr and villfa reacted with thumbs up emoji

@chalasr
Copy link
Member

Thank you@villfa.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@welcoMatticwelcoMatticwelcoMattic approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

BC Break when using Redis transport with an empty username

6 participants

@villfa@carsonbot@derrabus@chalasr@nicolas-grekas@welcoMattic
[8]ページ先頭
©2009-2025 Movatter.jp