Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DependencyInjection] autowire union and intersection types#43479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ea29ed6 to9830bd3Comparedunglas approved these changesOct 13, 2021
9830bd3 toaba31f9Compareogizanagi approved these changesOct 13, 2021
chalasr approved these changesOct 13, 2021
derrabus approved these changesOct 13, 2021
Member
derrabus commentedOct 13, 2021
Thank you Nicolas. |
2 tasks
nicolas-grekas added a commit that referenced this pull requestNov 6, 2021
… together with `ServiceSubscriberInterface` (kbond)This PR was squashed before being merged into the 5.4 branch.Discussion----------[DependencyInjection] Fix support for unions/intersections together with `ServiceSubscriberInterface`| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -Continuation of#43479 per [discussion](#43913 (comment)) with `@nicolas`-grekas.Todo:- [x] intersection type support/tests- [x] `ServiceSubscriberTrait` supportCommits-------123842a [DependencyInjection] Fix support for unions/intersections together with `ServiceSubscriberInterface`
xabbuh added a commit that referenced this pull requestJul 20, 2022
…message (xabbuh)This PR was merged into the 5.4 branch.Discussion----------[DependencyInjection] fix expected autowiring exception message| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets || License | MIT| Doc PR |types are sorted since#43479 in 5.4+Commits-------1373257 fix expected autowiring exception message
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR allows autowiring an argument of type
NormalizerInterface&DenormalizerInterfaceif both individual types have a corresponding autowiring alias, and if both aliases point to the very same service.This works the same with union types.