NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[HttpFoundation] Deprecate passing null as $requestIp in IpUtils#43411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:5.4fromW0rma:deprecate-null-iputils-check-ip

Oct 16, 2021

Merged

[HttpFoundation] Deprecate passing null as $requestIp in IpUtils#43411

fabpot merged 1 commit intosymfony:5.4fromW0rma:deprecate-null-iputils-check-ip

Oct 16, 2021

Conversation

Copy link

Contributor

W0rma commentedOct 12, 2021

Q	A
Branch?	5.4
Bug fix?	no
New feature?	no
Deprecations?	yes
Tickets	#43350 (comment)
License	MIT
Doc PR

carsonbot added Status: Needs Review Deprecation HttpFoundation labels

Oct 12, 2021

carsonbot added this to the5.4 milestone

Oct 12, 2021

Copy link

carsonbot commentedOct 13, 2021

Hey!

I think@a-menshchikov has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

derrabus requested changes

Oct 13, 2021

View reviewed changes

Copy link

Member

derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for working on this topic!

Let's avoid thecheckIp() if the IP to check isnull. We already know the result.

UPGRADE-5.4.md OutdatedShow resolvedHide resolved

src/Symfony/Component/HttpClient/NoPrivateNetworkHttpClient.php OutdatedShow resolvedHide resolved

src/Symfony/Component/HttpKernel/HttpCache/SubRequestHandler.php OutdatedShow resolvedHide resolved

src/Symfony/Component/HttpFoundation/Tests/IpUtilsTest.phpShow resolvedHide resolved

carsonbot added Status: Needs Work and removed Status: Needs Review labels

Oct 13, 2021

W0rma force-pushed thedeprecate-null-iputils-check-ip branch 2 times, most recently from2bac0cf todca654dCompare

October 15, 2021 17:15

Deprecate passing null as $requestIp to IpUtils::checkIp(), checkIp4(…

55e3a5b

…) and checkIp6()

W0rma force-pushed thedeprecate-null-iputils-check-ip branch fromdca654d to55e3a5bCompare

October 15, 2021 17:19

W0rma requested a review fromderrabus

October 15, 2021 17:24

carsonbot added Status: Needs Review and removed Status: Needs Work labels

Oct 15, 2021

derrabus approved these changes

Oct 16, 2021

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Oct 16, 2021

fabpot approved these changes

Oct 16, 2021

View reviewed changes

Copy link

Member

fabpot commentedOct 16, 2021

Thank you@W0rma.

fabpot merged commita53a173 intosymfony:5.4

Oct 16, 2021

W0rma mentioned this pull request

Oct 17, 2021

[HttpFoundation] Remove possibility to pass null as $requestIp in IpUtils#43550

Merged

fabpot added a commit that referenced this pull request

Oct 18, 2021

feature#43550[HttpFoundation] Remove possibility to pass null as $r…

be8401b

…equestIp in IpUtils (W0rma)This PR was merged into the 6.0 branch.Discussion----------[HttpFoundation] Remove possibility to pass null as $requestIp in IpUtils| Q             | A| ------------- | ---| Branch?       | 6.0| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       |#43350 (comment)| License       | MIT| Doc PR        |Removes the code which was deprecated in#43411Commits-------e95e97d Remove possibility to pass null as $requestIp in IpUtils

This was referencedNov 5, 2021

Release v5.4.0-BETA1#43937

Merged

Release v6.0.0-BETA1#43939

Merged

W0rma deleted the deprecate-null-iputils-check-ip branch

November 7, 2021 10:14