NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Security] Move`TraceableAuthenticator` to`security-http`#43401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:5.4fromchalasr:mv-trace-auth

Oct 12, 2021

Merged

[Security] Move`TraceableAuthenticator` to`security-http`#43401

fabpot merged 1 commit intosymfony:5.4fromchalasr:mv-trace-auth

Oct 12, 2021

Conversation

Copy link

Member

chalasr commentedOct 11, 2021

Q	A
Branch?	5.4
Bug fix?	no
New feature?	no
Deprecations?	no
Tickets	-
License	MIT
Doc PR	-

Necessary to fix tests on branch 6.0https://github.com/symfony/symfony/runs/3861906767.

There is an incompatible signature forAuthenticatorInterface::createAuthenticatedToken() between security-bundle 6.0 and security-http 5.4 because of the deprecatedPassportInterface type.
MovingTraceableAuthenticator andTraceableAuthenticatorManagerListener tosecurity-http fixes the issue and it's looking good to me.