Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[HttpClient] Fix RetryableHttpClient yielding a null chunk#43400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
miguelantoniosantos wants to merge1 commit intosymfony:5.4frommiguelantoniosantos:ticket_43390
Closed

[HttpClient] Fix RetryableHttpClient yielding a null chunk#43400

miguelantoniosantos wants to merge1 commit intosymfony:5.4frommiguelantoniosantos:ticket_43390

Conversation

@miguelantoniosantos
QA
Branch?5.3
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#43390
LicenseMIT
Doc PR

RetryableHttpClient was yield a null chuck to AsyncResponse throwing an LogicException (AsyncResponse.php:361).

I wasn't able to create a unit test as it requires constant adjustments on the timeout to trigger this issue as described on#43390

This is my first PR on symfony, so please do tell me if I did something wrong.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@miguelantoniosantos
Copy link
Author

Sorry about the closure and reopen, was trying to fix an issue with fabbot and rebases...

@carsonbot
Copy link

Hey!

I think@fancyweb has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@derrabusderrabus modified the milestones:5.4,5.3Oct 13, 2021
@derrabus
Copy link
Member

Since this bug affects Symfony 5.3, we should target the 5.3 branch.

@miguelantoniosantos
Copy link
Author

Seems like this is targetting 5.4 instead of 5.3, let me try to fix this

@nicolas-grekas
Copy link
Member

I had a closer look and decided to go with#43537 instead.
Thank you@miguelantoniosantos for giving this a try, next time might the good one :)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@chalasrchalasrAwaiting requested review from chalasr

@dunglasdunglasAwaiting requested review from dunglas

@jderussejderusseAwaiting requested review from jderusse

@lyrixxlyrixxAwaiting requested review from lyrixx

@OskarStarkOskarStarkAwaiting requested review from OskarStark

@srozesrozeAwaiting requested review from sroze

@wouterjwouterjAwaiting requested review from wouterj

@xabbuhxabbuhAwaiting requested review from xabbuh

@ycerutoycerutoAwaiting requested review from yceruto

Assignees

No one assigned

Projects

None yet

Milestone

5.3

Development

Successfully merging this pull request may close these issues.

[HttpClient] LogicException thrown while streaming redirected requests with RetryableHttpClient

4 participants

@miguelantoniosantos@carsonbot@derrabus@nicolas-grekas

[8]ページ先頭

©2009-2025 Movatter.jp