Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DependencyInjection] Extend TaggedIterator and TaggedLocator Attributes with able to specify defaultIndexMethod for #[TaggerIterator] and #[TaggedLocator]#43386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4fromfractalzombie:add-possibility-to-specify-default-index-method-for-attributes
Oct 19, 2021
Merged

[DependencyInjection] Extend TaggedIterator and TaggedLocator Attributes with able to specify defaultIndexMethod for #[TaggerIterator] and #[TaggedLocator]#43386

fabpot merged 1 commit intosymfony:5.4fromfractalzombie:add-possibility-to-specify-default-index-method-for-attributes
Oct 19, 2021

Conversation

@fractalzombie
Copy link
Contributor

@fractalzombiefractalzombie commentedOct 10, 2021•
edited by nicolas-grekas
Loading

QA
Branch?5.4
Bugfix?no
New feature?yes (updated)
Deprecations?no
Ticketsno ticket, the only contribution for fun and enjoy
LicenseMIT
Doc PRno, it's not a new feature, this we can do through YAML, but not through new PHP attributes, now we can do it through attributes.

Just extended one attribute that do not break compatibility, is optional and null.
The feature only allows you to do almost the same as in YAML files, the configuration specifying defaultIndexMethod for:

-  \ Symfony \ Component \ DependencyInjection \ Attribute \ TaggedIterator-  \ Symfony \ Component \ DependencyInjection \ Attribute \ TaggedLocator

LukasAddon and zmitic reacted with thumbs up emojizmitic reacted with heart emoji
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

I think@l-vo has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@fractalzombie
Copy link
ContributorAuthor

Hey hello! Can somebody review this PR?)

@fractalzombie
Copy link
ContributorAuthor

fractalzombie commentedOct 15, 2021•
edited
Loading

@nicolas-grekas Done :) Add some new tests for all of the cases with TaggedIterator and TaggedLocator with defaultIndexMethod, defaultPriorityMethod, and both of them together.

@fractalzombie
Copy link
ContributorAuthor

Hello!) Can some one review PR please?)

@fabpot
Copy link
Member

@fractalzombie Can you change the target to 5.4? Thank you.

@fractalzombiefractalzombie changed the base branch from5.4 to6.0October 18, 2021 18:55
@fractalzombie
Copy link
ContributorAuthor

@fractalzombie Can you change the target to 5.4? Thank you.

Many conflict files, or it's ok for now?

@nicolas-grekas
Copy link
Member

Yes, please fix the conflicts while rebasing. We'll handle the reverse conflicts when merging 5.4 into 6.0.

@fractalzombiefractalzombie changed the base branch from6.0 to5.4October 18, 2021 21:06
@fractalzombie
Copy link
ContributorAuthor

fractalzombie commentedOct 19, 2021•
edited
Loading

Yes, please fix the conflicts while rebasing. We'll handle the reverse conflicts when merging 5.4 into 6.0.

Solve conflicts, for now it's all is ok)

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, please apply fabbot's patch and we'll be good!

…tes with able to specify defaultIndexMethod and defaultPriorityMethod for #[TaggerIterator] and #[TaggedLocator]
@fractalzombie
Copy link
ContributorAuthor

Thanks, please apply fabbot's patch and we'll be good!

Done :)

@fabpot
Copy link
Member

Thank you@fractalzombie.

@fractalzombie
Copy link
ContributorAuthor

Thank you@fractalzombie.

Thanks to you guys too.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

@chalasrchalasrAwaiting requested review from chalasr

@jderussejderusseAwaiting requested review from jderusse

@lyrixxlyrixxAwaiting requested review from lyrixx

@OskarStarkOskarStarkAwaiting requested review from OskarStark

@srozesrozeAwaiting requested review from sroze

@wouterjwouterjAwaiting requested review from wouterj

@xabbuhxabbuhAwaiting requested review from xabbuh

@ycerutoycerutoAwaiting requested review from yceruto

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

4 participants

@fractalzombie@carsonbot@fabpot@nicolas-grekas
[8]ページ先頭
©2009-2025 Movatter.jp