NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[HttpFoundation] Deprecate upload_progress.* and url_rewriter.tags session options#43378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:5.4fromkafene:deprecate_session_upload_progress

Oct 13, 2021

Merged

[HttpFoundation] Deprecate upload_progress.* and url_rewriter.tags session options#43378

fabpot merged 1 commit intosymfony:5.4fromkafene:deprecate_session_upload_progress

Oct 13, 2021

Conversation

Copy link

kafene commentedOct 8, 2021

Q	A
Branch?	5.4
Bug fix?	no
New feature?	no
Deprecations?	yes
Tickets	Fix#43284
License	MIT

Related toissue #43284.

Deprecate support for configuring session.upload_progress.* - these options arePHP_INI_PERDIR options and can not be configured at runtime viaini_set.

Deprecate support for configuringurl_rewriter.tags - as of PHP 7.1.0, this option is no longer used for session configuration and that setting is nowsession.trans_sid_tags.url_rewriter.tags is used only byoutput_add_rewrite_var.

I wasn't sure about writing a test for this. I couldn't find any other places that deprecation notices were being tested. However the existing HttpFoundation test usesurl_rewriter.tags and I can see the new deprecation notice when runningphp ./phpunit src/Symfony/Component/HttpFoundation/ -- it may be appropriate to update that to use a new option.

carsonbot added Status: Needs Review Deprecation HttpFoundation labels

Oct 8, 2021

carsonbot added this to the5.4 milestone

Oct 8, 2021

Copy link

carsonbot commentedOct 8, 2021

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot