This PR fixes a bug of validating a runtime class from the composer paramextra.runtime.class. When provided, it always fails. Taking as an example theRuntime\Swoole\Runtime of theruntime/swoole package, when executing thecomposer dump-autoload, it ends with the following exception, even though theruntime/swoole package was installed.

 [InvalidArgumentException] Class "Runtime\Swoole\Runtime" listed under "extra.runtime.class" in your composer.json file not found.

When a composer plugin is executed, the composer autoloader for the project is not registered, thereby any reference to a class from installed packages won't work.
The fix drops this check to avoid it. I don't think it's worth checking here if a runtime class is valid or not. For instance, anything that comes from the$_SERVER['APP_RUNTIME'] is accepted, nothing is validated.

[Runtime] Drop class validation of composer "extra.runtime.class"

13f69f2

carsonbot added Status: Needs Review Bug Runtime labels

Oct 8, 2021

carsonbot added this to the5.3 milestone

Oct 8, 2021

piku235 changed the title~~[Runtime] Drop class validation of composer "extra.runtime.class"~~[Runtime] Fix class validation of composer "extra.runtime.class"

Oct 8, 2021

Copy link

Contributor

Ahummeling commentedOct 12, 2021•
edited
Loading

Perhaps this issue can be resolved without omitting the check entirely. Could it be the case that theclass_exists($runtimeClass) call is responsible for the failed autoload? If so, does the issue still occur when passingfalse as second parameter to prevent calling autoload by default?

Copy link

ContributorAuthor

piku235 commentedOct 13, 2021•
edited
Loading

@Ahummelin I'd also like to keep it, but because of how things internally work for composer plugins it seems hard to get and therefore not worth it. The issue is more about theis_subclass_of() call in the if statement. When a class does not exist, it tries to reach registered autoloaders, but as the most important one - responsible for project dependencies is not registered when a composer plugin is executed, it returns alwaysfalse.

Ahummeling approved these changes

Oct 13, 2021

View reviewed changes

Copy link

Contributor

Ahummeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yeah I see what you mean now, going over the doc foris_subclass_of, seems that the autoloader can be disabled, but then you'd need to get an instance of the class, which was what we're trying to get around in the first place...

With that said, I think the PR looks good