Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Cache] Split PdoAdapter into DoctrineDbalAdapter#43362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4fromGromNaN:dbal/cache-pdo-5.4
Oct 19, 2021

Conversation

@GromNaN
Copy link
Member

@GromNaNGromNaN commentedOct 7, 2021•
edited
Loading

QA
Branch?5.4
Bug fix?no
New feature?yes
Deprecations?yes
TicketsFix#42962
LicenseMIT
Doc PRsymfony/symfony-docs#15903

@GromNaNGromNaN requested a review fromstofOctober 8, 2021 12:46
@GromNaNGromNaNforce-pushed thedbal/cache-pdo-5.4 branch 6 times, most recently from114ff31 to6a587b8CompareOctober 8, 2021 19:29
@GromNaN
Copy link
MemberAuthor

Tests are green.
Tested locally with mysql & postgres.

Comment on lines 26 to 28
if (!class_exists(DoctrineSchemaConfiguratorInterface::class)) {
$this->markTestSkipped('This test requires symfony/cache >=5.4');
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You've bumped thedoctrine/cache dependency to 5.4, so this block should not be needed.

GromNaN reacted with thumbs up emoji
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Removed this check, but the test will fail till the PR get merged into 5.4

Symfony\Bridge\Doctrine\Tests\SchemaListener\DoctrineDbalCacheAdapterSchemaSubscriberTest::testPostGenerateSchemaPHPUnit\Framework\MockObject\UnknownTypeException: Class or interface "Symfony\Component\Cache\Adapter\DoctrineSchemaConfiguratorInterface" does not exist

@GromNaNGromNaNforce-pushed thedbal/cache-pdo-5.4 branch 2 times, most recently from4c1a11a tof0775dfCompareOctober 11, 2021 19:37
@fabpot
Copy link
Member

Thank you@GromNaN.

GromNaN and derrabus reacted with hooray emoji

@fabpotfabpot merged commit4418be1 intosymfony:5.4Oct 19, 2021
This was referencedNov 5, 2021
@ostrolucky
Copy link
Contributor

ostrolucky commentedNov 14, 2021•
edited
Loading

Would be great if someone changed this in DoctrineBundle. I think that currently this functionality is silently broken with Symfony 6, because in bundle we use class_exists checks for deprecated class that was removed from Symfony 6. This is why I didn't make it easy for symfony folks to declare symfony 6 compatibility btw. This change came after we declared compatibility with Symfony 6 and now constraints are wrong because this is most likely broken.

edit: Ah looks like work is ongoing here alreadydoctrine/DoctrineBundle#1417

GromNaN reacted with eyes emoji

@GromNaNGromNaN deleted the dbal/cache-pdo-5.4 branchNovember 14, 2021 19:13
fabpot added a commit that referenced this pull requestNov 16, 2021
…s (andrew-demb)This PR was merged into the 5.4 branch.Discussion----------DoctrineDbalAdapter: Fix deprecation message placeholders| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets       | -  <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->| License       | MIT| Doc PR        | -. <!-- required for new features --><!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/releases): - Always add tests and ensure they pass. - Never break backward compatibility (seehttps://symfony.com/bc). - Bug fixes must be submitted against the lowest maintained branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too.) - Features and deprecations must be submitted against branch 5.x. - Changelog entry should followhttps://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry-->Deprecation introduced in#43362 has a typo in interpolation - wrong parameter orderCommits-------e3899f5 Fix deprecation message placeholders
fabpot added a commit that referenced this pull requestNov 17, 2021
…ter (GromNaN)This PR was merged into the 5.4 branch.Discussion----------[FrameworkBundle] Add framework config for DBAL cache adapter| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |doctrine/DoctrineBundle#1417| License       | MIT| Doc PR        | -The framework configuration was missing from#43362.Additionnaly, the depreciation message on `PdoCacheAdapterDoctrineSchemaSubscriber` must be removed. This class needs to be used in 5.4 whenever a `PdoAdapter` is used, because it could have a DBAL connection and we need to keep the deprecated behavior. A depreciation message is already triggered in the `PdoAdapter` itself when it gets a DBAL connection.Commits-------672545d Add framework config for DBAL cache adapter
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull requestDec 27, 2021
This PR was merged into the 5.4 branch.Discussion----------[Cache] Split PdoAdapter to DoctrineDbalAdapterIn Symfony 5.4, the `PdoAdapter` is split and `DoctrineDbalAdapter` is created.| Q             | A| ------------- | ---| Branch?       | 5.4| Tickets       |Fixsymfony/symfony#42962| Code PR        |symfony/symfony#43362Commits-------68fed1b [Cache] Split PdoAdapter to DoctrineDbalAdapter
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@derrabusderrabusderrabus approved these changes

@stofstofAwaiting requested review from stof

@fabpotfabpotAwaiting requested review from fabpot

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

Split PDO and DBAL adapters

6 participants

@GromNaN@fabpot@ostrolucky@stof@derrabus@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp