Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Messenger] Add worker metadata inside logs#43355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ruudk left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice!
okwinza left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
| pcntl_signal(\SIGTERM,function ()use ($event) { | ||
| if (null !==$this->logger) { | ||
| $this->logger->info('Received SIGTERM signal.'); | ||
| $this->logger->info('Received SIGTERM signal.', ['transportNames' =>$event->getWorker()->getMetadata()->getTransportNames()]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think we are using underscore names in such a situation, sotransport_names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@fabpot in fact, I've found both casescamelCase|snake_case in the codebase
I'll rework this but maybe it is needed a consensus here :)
6d6eca4 to649cb10Comparefabpot commentedOct 7, 2021
Thank you@94noni. |
Small PR related to one of my comment#42723 (comment) on the ticket PR: having this contextual info is valuable imho
cc@ruudk@okwinza@fabpot