NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Translation] [Bridge] [Lokalise] do not export empty strings#43312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

derrabus merged 1 commit intosymfony:5.3fromtaranovegor:lokalise-export-empty-as-skip

Oct 4, 2021

Merged

[Translation] [Bridge] [Lokalise] do not export empty strings#43312

derrabus merged 1 commit intosymfony:5.3fromtaranovegor:lokalise-export-empty-as-skip

Oct 4, 2021

Conversation

Copy link

Contributor

taranovegor commentedOct 4, 2021•
edited
Loading

Q	A
Branch?	5.3
Bug fix?	no
New feature?	no
Deprecations?	no
Tickets	~
License	MIT
Doc PR	~

This change excludes the possibility of receiving strings without translation. At the moment, all keys that have no translation in the Lokalise panel are empty strings after export.
Link to documentation describing the added parameter:https://app.lokalise.com/api2docs/curl/#transition-download-files-post

example w/o changes:

validators.es.xlf

TODO:

Changelog

taranovegor requested review fromOskarStark,chalasr,dunglas,jderusse,lyrixx,sroze,wouterj,xabbuh andyceruto ascode owners

October 4, 2021 15:16

carsonbot added Status: Needs Review Translation labels

Oct 4, 2021

carsonbot added this to the5.3 milestone

Oct 4, 2021

Copy link

carsonbot commentedOct 4, 2021

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

[Translation] [Bridge] [Lokalise] do not export empty strings

1b68040

welcoMattic approved these changes

Oct 4, 2021

View reviewed changes

Copy link

Member

welcoMattic left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@taranovegor, I think it's ok to accept this fix, because we want to fallback to the fallback locale as soon as possible when a translation is empty.