Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpClient] Add method to set response factory in mock client#43280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@greeflas
Copy link
Contributor

QA
Branch?5.4
Bug fix?no
New feature?yes
Deprecations?no
TicketsFix#40620
LicenseMIT
Doc PRsymfony/symfony-docs#15883

lmillucci, norkunas, and derrabus reacted with thumbs up emoji
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(with minor comments)

@greeflasgreeflasforce-pushed theticket_40620_setter_for_response_factory branch from7fe3331 to59f7564CompareOctober 2, 2021 10:04
@derrabus
Copy link
Member

Thank you for this PR. I agree with the changes, but I think we should add a test.

greeflas reacted with thumbs up emoji

@nicolas-grekasnicolas-grekasforce-pushed theticket_40620_setter_for_response_factory branch fromae403bf to2e028ccCompareOctober 5, 2021 07:51
@nicolas-grekas
Copy link
Member

Thank you@greeflas.

greeflas reacted with hooray emoji

@nicolas-grekasnicolas-grekas merged commit3e387cf intosymfony:5.4Oct 5, 2021
This was referencedNov 5, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@derrabusderrabusderrabus approved these changes

+2 more reviewers

@norkunasnorkunasnorkunas left review comments

@lmilluccilmilluccilmillucci left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

[HttpClient] Allow MockHttpClient $responseFactory to be modifiable though accessors

6 participants

@greeflas@carsonbot@derrabus@nicolas-grekas@norkunas@lmillucci
[8]ページ先頭
©2009-2025 Movatter.jp