Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[PhpUnitBridge] Do not override correct triggering file for return type deprecations#43241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
fabpot merged 1 commit intosymfony:5.3fromwouterj:bugfix/indirect-return-type-deprecationsSep 29, 2021
Merged
[PhpUnitBridge] Do not override correct triggering file for return type deprecations#43241
fabpot merged 1 commit intosymfony:5.3fromwouterj:bugfix/indirect-return-type-deprecationsSep 29, 2021
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
MemberAuthor
wouterj commentedSep 28, 2021
Btw, we can also once again reword the deprecation message to fit the standard set by all other deprecation messages. I'm all ears for suggestions :) |
nicolas-grekas approved these changesSep 29, 2021
fabpot approved these changesSep 29, 2021
Member
fabpot commentedSep 29, 2021
Isn't it something for 5.3? |
1 task
Member
fabpot commentedSep 29, 2021
Thank you@wouterj. |
7f416d5 to9bcfddeComparenicolas-grekas added a commit that referenced this pull requestSep 30, 2021
…r missing return types on 5.3 (chalasr)This PR was merged into the 5.3 branch.Discussion----------[PhpUnitBridge] Fix skipping triggering file override for missing return types on 5.3| Q | A| ------------- | ---| Branch? | 5.3| Bug fix? | yes| New feature? | no| Deprecations? | -| Tickets | -| License | MIT| Doc PR | -#43241 was merged in 5.3 instead of 5.4, but the deprecation notice was reworded on 5.4:#42935.Commits-------c1034dc [PHPUnitBridge] Fix skipping triggering file override on 5.3
symfony-splitter pushed a commit to symfony/phpunit-bridge that referenced this pull requestSep 30, 2021
…r missing return types on 5.3 (chalasr)This PR was merged into the 5.3 branch.Discussion----------[PhpUnitBridge] Fix skipping triggering file override for missing return types on 5.3| Q | A| ------------- | ---| Branch? | 5.3| Bug fix? | yes| New feature? | no| Deprecations? | -| Tickets | -| License | MIT| Doc PR | -symfony/symfony#43241 was merged in 5.3 instead of 5.4, but the deprecation notice was reworded on 5.4:symfony/symfony#42935.Commits-------c1034dc940 [PHPUnitBridge] Fix skipping triggering file override on 5.3
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return type deprecations were sometimes incorrectly marked as direct/indirect, even when they occur on a vendor package. This is due to their special message, which starts with
Method "classFromVendor::method()" might add "type" [...] do the same in "affectedClass" [...](normal messages start with the affected class).This means that the deprecation type checked whether the method causing the deprecation was inside the vendor directory, rather than the method affected by the deprecation. Even more, if the causing method was from PHP internals,
$this->triggeringFilewould becomefalse, causingrealpath(false)to return the current directory - meaning these were always marked as direct.