Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Security] Remove annoying deprecation inUsageTrackingTokenStorage#43235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.3fromchalasr:security-helper-noreq
Sep 29, 2021

Conversation

@chalasr
Copy link
Member

QA
Branch?5.3
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#43042
LicenseMIT
Doc PR-

@chalasrchalasrforce-pushed thesecurity-helper-noreq branch 3 times, most recently from07b7ffc to152024eCompareSeptember 28, 2021 13:10
Copy link
Member

@jderussejderusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Small nitpicking

@chalasr
Copy link
MemberAuthor

There might be a simpler solution:#43042 (comment).
Don't merge yet.

@chalasrchalasr changed the title[Security] Disable session usage tracking fromSecurity helper when there is no request[Security] Remove annoying deprecation inUsageTrackingTokenStorageSep 28, 2021
@chalasr
Copy link
MemberAuthor

PR updated to revert the deprecation instead. It was introduced in#40785 but is not strictly needed.

@fabpot
Copy link
Member

Thank you@chalasr.

@fabpotfabpot merged commit4b3d3e0 intosymfony:5.3Sep 29, 2021
@chalasrchalasr deleted the security-helper-noreq branchSeptember 29, 2021 11:16
@derrabus
Copy link
Member

@chalasr Can you please do the merge from 5.4 to 6.0? I was unsure if I need to revert anything when merging up, now that the deprecation has been reverted.

@chalasr
Copy link
MemberAuthor

@derrabus sure, done

derrabus reacted with heart emoji

@fabpotfabpot mentioned this pull requestOct 29, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@jderussejderussejderusse approved these changes

@derrabusderrabusderrabus approved these changes

@wouterjwouterjAwaiting requested review from wouterjwouterj is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

5.3

Development

Successfully merging this pull request may close these issues.

5 participants

@chalasr@fabpot@derrabus@jderusse@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp