Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Serializer] Attributes that extend serializer`s annotations are not ignored by the serialization process#43208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:5.3fromonatskyy:ticket_43207
Sep 29, 2021

Conversation

@onatskyy
Copy link

@onatskyyonatskyy commentedSep 28, 2021•
edited
Loading

QA
Branch?5.3 for bug fixes
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#43207
LicenseMIT
Doc PR

wRLSS, paramonov, sauron918, ulfheddin, and ging-dev reacted with thumbs up emoji
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@onatskyyonatskyy changed the base branch from5.4 to5.3September 28, 2021 08:31
@onatskyyonatskyy changed the title[Serializer] Attributes that extends the serializer`s annotations do …[Serializer] Attributes that extend serializer`s annotations are not ignored by the serialization processSep 28, 2021
Copy link
Member

@dunglasdunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Maybe should we have marked these news attributes asfinal as I'm not sure that it's a good practice to extend them. But LGTM otherwise.

@nicolas-grekasnicolas-grekas modified the milestones:5.4,5.3Sep 29, 2021
@nicolas-grekas
Copy link
Member

Thank you@onatskyy.

@nicolas-grekasnicolas-grekas merged commit545fc34 intosymfony:5.3Sep 29, 2021
@fabpotfabpot mentioned this pull requestOct 29, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@dunglasdunglasdunglas approved these changes

+1 more reviewer

@kester36kester36kester36 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.3

Development

Successfully merging this pull request may close these issues.

5 participants

@onatskyy@carsonbot@nicolas-grekas@dunglas@kester36
[8]ページ先頭
©2009-2025 Movatter.jp