Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Workflow] Add missing audit-trail settings in framework workflow con…#43206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedSep 28, 2021
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
271a525 toec55c22Comparelyrixx commentedSep 28, 2021
Thanks for finding this issue Could you update some test to ensure not regression could happen? Thanks |
ec55c22 to6d2b71eComparetemp commentedSep 28, 2021
Just pushed the test! |
fabpot commentedSep 28, 2021
Thank you@temp. |
| <xsd:attributename="enabled"type="xsd:boolean" /> | ||
| </xsd:complexType> | ||
| <xsd:simpleTypename="audit_trail_enabled"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this simple type looks unused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This PR was merged into the 5.3 branch.Discussion----------[Workflow] Remove unused code in XML schemas| Q | A| ------------- | ---| Branch? | 5.3| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets |#43206 (review)| License | MIT| Doc PR |Commits-------0ef7789 [Workflow] Remove dead code in XML schemas
audit-trail config was missing in xsd. Example from symfony.com did not work as expected due to this.
Commit adds audit-trail in xsd