Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Serializer] Fix denormalizing XML array with empty body (5.x)#43204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.3fromalexandre-daubois:fix/xml-empty-array
Sep 29, 2021

Conversation

@alexandre-daubois
Copy link
Member

@alexandre-dauboisalexandre-daubois commentedSep 27, 2021•
edited
Loading

This happens for example with XML empty tags denormalizing to an object array attribute.

QA
Branch?5.3
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#43193 on Symfony 5.x
LicenseMIT
Doc PRNA

Fix for 4.4 can be found in#43205

@carsonbotcarsonbot added this to the5.3 milestoneSep 27, 2021
@alexandre-dauboisalexandre-daubois changed the title[Serializer] Fix denormalizing of array with empty body[Serializer] Fix denormalizing of array with empty body (5.x)Sep 27, 2021
@alexandre-dauboisalexandre-daubois changed the title[Serializer] Fix denormalizing of array with empty body (5.x)[Serializer] Fix denormalizing XML array with empty body (5.x)Sep 28, 2021
@carsonbot
Copy link

Hey!

I think@mkrauser has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

dunglas
dunglas previously approved these changesSep 28, 2021
Copy link
Member

@dunglasdunglas left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

This happens for example with XML empty tags denormalizing to an object array attribute.
fabpot added a commit that referenced this pull requestSep 29, 2021
…4.4) (alexandre-daubois)This PR was merged into the 4.4 branch.Discussion----------[Serializer] Fix denormalizing XML array with empty body (4.4)This happens for example with XML empty tags denormalizing to an object array attribute.| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |Fix#43193 on Symfony 4.4| License       | MIT| Doc PR        | _NA_Not sure how to deal with versions differences as they differ just a little bit. Anyway, here's the fix for 4.4 and you can find the fix for 5.x on#43204 😄Commits-------d6b7e2d [Serializer] Fix denormalizing of array with empty body
@fabpot
Copy link
Member

Thank you@alexandre-daubois.

@fabpotfabpot merged commit500ffa2 intosymfony:5.3Sep 29, 2021
@alexandre-dauboisalexandre-daubois deleted the fix/xml-empty-array branchSeptember 29, 2021 06:50
@fabpotfabpot mentioned this pull requestOct 29, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@dunglasdunglasdunglas approved these changes

@lyrixxlyrixxlyrixx approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.3

Development

Successfully merging this pull request may close these issues.

5 participants

@alexandre-daubois@carsonbot@fabpot@dunglas@lyrixx
[8]ページ先頭
©2009-2025 Movatter.jp