Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Runtime] tweak config for env var names#43201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
chalasr approved these changesSep 27, 2021
fabpot approved these changesSep 27, 2021
Contributor
maxhelias commentedSep 27, 2021
You should also adapt the test in src/Symfony/Component/Runtime/Tests/phpt/runtime-options.php |
Member
fabpot commentedSep 27, 2021
Thank you@nicolas-grekas. |
MemberAuthor
nicolas-grekas commentedSep 27, 2021
@maxhelias would you mind sending a PR to fix tests? (aka ensuring they fail before fixing them ;) ) |
nicolas-grekas added a commit that referenced this pull requestSep 29, 2021
This PR was merged into the 5.4 branch.Discussion----------[Runtime] Fix test for env var names| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -Fix#43201 (comment)Commits-------a6d37ff [Runtime] Fix test for env var names
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tweaking#41608