NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[SecurityBundle] Fixed LogicException message of FirewallAwareTrait#43146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:5.3fromfkropfhamer:fix/firewallawairetrait-error

Sep 26, 2021

Merged

[SecurityBundle] Fixed LogicException message of FirewallAwareTrait#43146

fabpot merged 1 commit intosymfony:5.3fromfkropfhamer:fix/firewallawairetrait-error

Sep 26, 2021

Conversation

Copy link

Contributor

fkropfhamer commentedSep 23, 2021

Q	A
Branch?	5.4 for features / 4.4 or 5.3 for bug fixes
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix#43145
License	MIT
Doc PR	symfony/symfony-docs#...

fkropfhamer requested review fromchalasr andwouterj ascode owners

September 23, 2021 10:39

carsonbot added Status: Needs Review Bug labels

Sep 23, 2021

carsonbot added this to the5.4 milestone

Sep 23, 2021

Copy link

carsonbot commentedSep 23, 2021

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

derrabus modified the milestones:5.4,5.3

Sep 23, 2021

derrabus added the SecurityBundle label

Sep 23, 2021

carsonbot changed the title~~Fixed LogicException message of FirewallAwareTrait.~~[SecurityBundle] Fixed LogicException message of FirewallAwareTrait.

Sep 23, 2021

derrabus approved these changes

Sep 23, 2021

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Sep 23, 2021

derrabus changed the title~~[SecurityBundle] Fixed LogicException message of FirewallAwareTrait.~~[SecurityBundle] Fixed LogicException message of FirewallAwareTrait

Sep 23, 2021

Copy link

Member

derrabus commentedSep 23, 2021

The change looks correct from my perspective. Would you be able to provide a failing test for your issue?

Copy link

ContributorAuthor

fkropfhamer commentedSep 23, 2021

@derrabus Do you mean a unit test?

Copy link

Member

derrabus commentedSep 23, 2021

Yes. A unit test that fails without and passes with your change.

Copy link

ContributorAuthor

fkropfhamer commentedSep 23, 2021

Ok, I will try!

nicolas-grekas reviewed

Sep 24, 2021

View reviewed changes

Copy link

Member

nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

we prefer using real instances instead of mocks when possible
can you please have a look at your test with this in mind?
(we can use mocks when creating a real instance is too complex of course)