Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Notifier] Add sms77 Notifier Bridge#43134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedSep 22, 2021
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
carsonbot commentedSep 22, 2021
It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you. Cheers! Carsonbot |
carsonbot commentedSep 23, 2021
Hey! I think@qdequippe has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Notifier/Bridge/Sms77/Tests/Sms77TransportFactoryTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
OskarStark left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Only some minor things
Fix typos in src/Symfony/Component/Notifier/Bridge/Sms77/README.md
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
OskarStark commentedSep 29, 2021
Please check fabbot and fix the coding standards. Thanks |
fabpot commentedOct 13, 2021
Thank you@matthiez. |
This PR was squashed before being merged into the 5.4 branch.Discussion----------[Notifier] Add sms77 Notifier Bridge| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | no| New feature? | yes| Deprecations? | no| License | MIT| Doc PR | [symfony/symfony-docs/pull/15840](symfony/symfony-docs#15840)| Recipe PR | [symfony/recipes/pull/1003](symfony/recipes#1003)Add sms77 bridge to Symfony Notifier.A Germany based SMS provider established in 2003.Commits-------6d5be78 [Notifier] Add sms77 Notifier Bridge
Add sms77 bridge to Symfony Notifier.
A Germany based SMS provider established in 2003.