Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Messenger] [Redis] Allow authentication with user and password#43124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
chalasr merged 1 commit intosymfony:4.4fromGaryPEGEOT:fix/messenger-redis-auth
Sep 24, 2021
Merged

[Messenger] [Redis] Allow authentication with user and password#43124

chalasr merged 1 commit intosymfony:4.4fromGaryPEGEOT:fix/messenger-redis-auth
Sep 24, 2021

Conversation

@GaryPEGEOT
Copy link
Contributor

QA
Branch?5.3
Bug fix?yes
New feature?no
Deprecations?no
Tickets
LicenseMIT
Doc PRN/A

Allow to authenticate on Redis with userand password, instead of only password

JimmyCastiel and welcoMattic reacted with thumbs up emoji
@carsonbotcarsonbot added this to the5.3 milestoneSep 21, 2021
@carsonbotcarsonbot changed the title[Messenger][Redis] Allow authentication with user and password[Messenger] [Redis] Allow authentication with user and passwordSep 21, 2021
@derrabus
Copy link
Member

Is 4.4 affected by this bug as well?

@GaryPEGEOT
Copy link
ContributorAuthor

Is 4.4 affected by this bug as well?

File did not exists in 4.4 !

@derrabus
Copy link
Member

File did not exists in 4.4 !

That was not my question. 😉 Messenger 4.4 did have support for Redis and the logic was eventually moved to the file you're fixing here.

@fabpot
Copy link
Member

I suppose the code was insrc/Symfony/Component/Messenger/Transport/RedisExt/Connection.php in 4.4.

GaryPEGEOT and derrabus reacted with thumbs up emoji

@GaryPEGEOT
Copy link
ContributorAuthor

Ok, my bad! should backport the PR to 4.4 as well@fabpot ?

@chalasr
Copy link
Member

Please rebase on 4.4 and do the change on that file, yes. We will take care of applying the patch to the new location when merging up.

@GaryPEGEOT
Copy link
ContributorAuthor

@chalasr I've changed the base branch & files :)

chalasr reacted with thumbs up emoji

@chalasr
Copy link
Member

Thank you@GaryPEGEOT.

GaryPEGEOT and JimmyCastiel reacted with thumbs up emoji

@chalasrchalasr merged commitc9275a9 intosymfony:4.4Sep 24, 2021
@GaryPEGEOTGaryPEGEOT deleted the fix/messenger-redis-auth branchSeptember 24, 2021 10:45
This was referencedSep 28, 2021
chalasr added a commit that referenced this pull requestOct 24, 2021
…llfa)This PR was merged into the 4.4 branch.Discussion----------[Messenger] Fix Redis Transport when username is empty| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |Fix#43306| License       | MIT| Doc PR        | n/aChecking the username and the password with `isset` is not enough. We also need to check they're not empty strings.This fixes the BC break introduced by#43124.See alsohttps://3v4l.org/iASnECommits-------cd66b8c [Messenger] Fix Redis Transport when username is empty
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jderussejderussejderusse approved these changes

@derrabusderrabusderrabus approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

6 participants

@GaryPEGEOT@derrabus@fabpot@chalasr@jderusse@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp