Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpFoundation] [PDO] Don't fetch time when reading the session#43120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.0fromIonBazan:pdo-session-cleanup
Sep 21, 2021

Conversation

@IonBazan
Copy link
Contributor

QA
Branch?6.0
Bug fix?no
New feature?no
Deprecations?no
Tickets
LicenseMIT
Doc PR

Following up#33169 (comment)

BTW is there a reason we are usingFETCH_NUM instead ofFETCH_ASSOC for more readability?

@carsonbotcarsonbot added this to the6.0 milestoneSep 21, 2021
@carsonbotcarsonbot changed the title[HttpFoundation][PDO] Don't fetch time when reading the session[HttpFoundation] [PDO] Don't fetch time when reading the sessionSep 21, 2021
@stof
Copy link
Member

BTW is there a reason we are usingFETCH_NUM instead ofFETCH_ASSOC for more readability?

Currently, the SQL does not guarantee fixed names for the fetched columns inFETCH_ASSOC mode as it does not alias them and the field names in the database are configurable. So this would make the code more complex.

IonBazan reacted with thumbs up emoji

@stof
Copy link
Member

Looks like this breaks some tests. Maybe they were relying on the BC layer by storing the lifetime instead of the expiry ?

@IonBazan
Copy link
ContributorAuthor

Thanks for explanation,@stof.
I will look into the test issues. Converting to draft for now.

@IonBazanIonBazan marked this pull request as draftSeptember 21, 2021 10:56
@IonBazanIonBazan marked this pull request as ready for reviewSeptember 21, 2021 11:12
@fabpot
Copy link
Member

Thank you@IonBazan.

IonBazan reacted with rocket emoji

@fabpotfabpot merged commitebe0bdd intosymfony:6.0Sep 21, 2021
@IonBazanIonBazan deleted the pdo-session-cleanup branchSeptember 22, 2021 03:33
fabpot added a commit that referenced this pull requestOct 12, 2021
…obion)This PR was merged into the 6.0 branch.Discussion----------[HttpFoundation] remove legacy session lifetime logic| Q             | A| ------------- | ---| Branch?       | 6.0| Bug fix?      | no| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets       || License       | MIT| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->This part was only relevant for keeping bc with the old lifetime data. Has been forgotten to be removed in#41334 and#43120Commits-------54a578b [HttpFoundation] remove legacy session lifetime logic
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@stofstofstof approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.0

Development

Successfully merging this pull request may close these issues.

4 participants

@IonBazan@stof@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp