Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Notifier] [Firebase] Only call setMessageId if valid message id#43097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@OskarStark
Copy link
Contributor

QA
Branch?5.3
Bug fix?yes
New feature?no
Deprecations?no
TicketsFollows#43073 (comment)
LicenseMIT
Doc PR---

@OskarStarkOskarStark self-assigned thisSep 19, 2021
@carsonbotcarsonbot added this to the5.3 milestoneSep 19, 2021
@carsonbotcarsonbot changed the title[Notifier][Firebase] Only call setMessageId if valid message id[Notifier] [Firebase] Only call setMessageId if valid message idSep 19, 2021
@fabpot
Copy link
Member

As I expect that most the time we will have a message id, I don't think this is needed.

@OskarStarkOskarStark deleted the fix/call-when-not-null branchJune 23, 2025 08:38
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotAwaiting requested review from fabpot

1 more reviewer

@noniagriconomienoniagriconomienoniagriconomie left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@OskarStarkOskarStark

Projects

None yet

Milestone

5.3

Development

Successfully merging this pull request may close these issues.

4 participants

@OskarStark@fabpot@noniagriconomie@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp