Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Messenger] UseTransportMessageIdStamp inInMemoryTransport allows retrying#43096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@alexndlm
Copy link
Contributor

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
LicenseMIT

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbotcarsonbot added this to the4.4 milestoneSep 19, 2021
@carsonbot
Copy link

Hey!

I think@tyx has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@okwinza
Copy link
Contributor

okwinza commentedSep 24, 2021•
edited
Loading

This seems to add some additional logic and thus feels more like a feature to me and should target 5.4 branch.
Are you sure it's a bug?

@alexndlm
Copy link
ContributorAuthor

This seems to add some additional logic and thus feels more like a feature to me and should target 5.4 branch.
Are you sure it's a bug?

For now, it is not possible to resend the same message with InMemory transport. I think it is a bug.

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Except from a minor comment, this makes ways more sense than the previous logic!

@nicolas-grekasnicolas-grekasforce-pushed thefeature/allow-retrying-for-in-memory-transport branch 2 times, most recently froma9feb76 to858236dCompareOctober 30, 2021 13:21
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I've updated your patch to my suggestion

@nicolas-grekasnicolas-grekasforce-pushed thefeature/allow-retrying-for-in-memory-transport branch 3 times, most recently from7642e86 to9ae6ae7CompareOctober 30, 2021 13:36
@nicolas-grekasnicolas-grekasforce-pushed thefeature/allow-retrying-for-in-memory-transport branch from9ae6ae7 to609b07dCompareOctober 30, 2021 13:41
@nicolas-grekas
Copy link
Member

Thank you@alexndlm.

alexndlm reacted with hooray emoji

@nicolas-grekasnicolas-grekas merged commit27d8daf intosymfony:4.4Oct 30, 2021
This was referencedNov 22, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@srozesrozeAwaiting requested review from sroze

@jderussejderusseAwaiting requested review from jderusse

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

5 participants

@alexndlm@carsonbot@okwinza@nicolas-grekas@jderusse
[8]ページ先頭
©2009-2025 Movatter.jp