Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Notifier] Update FirebaseTransport.php#43073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
src/Symfony/Component/Notifier/Bridge/Firebase/FirebaseTransport.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
| $sentMessage =newSentMessage($message, (string)$this); | ||
| $sentMessage->setMessageId($success['results'][0]['message_id']); | ||
| $sentMessage->setMessageId($success['results'][0]['message_id'] ??''); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Let's wrap this in an if Statement and do not call the setMessageId method
fabpot commentedSep 19, 2021
Thank you@dima-gr. |
OskarStark commentedSep 19, 2021
Now one need to check for null and empty string. I am still in favor of not calling the method to only return a string when it is a valid message id. WDYT@fabpot |
prevent setting null value from firebase response, previous pull request -#43040