Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Mailer] [Sendgrid] Fix test#43053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
chalasr merged 1 commit intosymfony:5.4fromchalasr:fix-sendgrid-mailer-req
Sep 16, 2021

Conversation

@chalasr
Copy link
Member

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

low-deps build is broken after#43018 because it uses symfony/mailer 4.4.x whileTagHeader is 5.x only.

@carsonbotcarsonbot changed the title[Mailer][Sendgrid] Fix symfony/mailer version constraint[Mailer] [Sendgrid] Fix symfony/mailer version constraintSep 16, 2021
@derrabus
Copy link
Member

I'm fine with bumping. However, we could get around it by skipping the new tests ifTagHeader is not present, couldn't we?

@chalasr
Copy link
MemberAuthor

We could indeed. I tend to prefer bumping over adding a skip condition here, but both work for me. Let me know about your preference

@chalasrchalasrforce-pushed thefix-sendgrid-mailer-req branch 2 times, most recently from73c946b to3d77313CompareSeptember 16, 2021 11:20
@chalasr
Copy link
MemberAuthor

PR updated, now skips the problematic test based on class existence.

@derrabus
Copy link
Member

Yes, I think that's better. We bump the dependency on the 6.0 branch anyway and can remove the skip condition there.

@derrabus
Copy link
Member

I think, the commit message and PR title deserve an update. Apart from that, let's merge to make the CI green again.

chalasr reacted with thumbs up emoji

@chalasrchalasr changed the title[Mailer] [Sendgrid] Fix symfony/mailer version constraint[Mailer] [Sendgrid] Fix testSep 16, 2021
@chalasrchalasr merged commit7167324 intosymfony:5.4Sep 16, 2021
@chalasrchalasr deleted the fix-sendgrid-mailer-req branchSeptember 16, 2021 15:52
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@derrabusderrabusderrabus approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chalasr@derrabus@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp