Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Mailer] Adding support for TagHeader and MetadataHeader to the Sendgrid API transport#43018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedSep 14, 2021
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
gnito-org commentedSep 14, 2021
I don't think the two failing tests were caused by this pull request. The 8.0, low deps test complains about |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Mailer/Bridge/Sendgrid/Transport/SendgridApiTransport.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Mailer/Bridge/Sendgrid/Transport/SendgridApiTransport.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Mailer/Bridge/Sendgrid/Transport/SendgridApiTransport.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
gnito-org commentedSep 15, 2021
@fabpot Thank you for your suggested changes. I coded it that way because I thought I was following Symfony standards by replicating the way that theMailchimp,Postmark, andSendinblue API transports were coded. |
fabpot commentedSep 15, 2021
Thank you@gnito-org. |
This PR was merged into the 5.4 branch.Discussion----------[Mailer] [Sendgrid] Fix test| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -low-deps build is broken after#43018 because it uses symfony/mailer 4.4.x while `TagHeader` is 5.x only.Commits-------375e95a [Mailer][Sendgrid] Fix test
I added support for tags and metadata to the Mailer Sendgrid API transport, in response to this discussion:#42481
The relevant Sendgrid API documentation is located at: