Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Display the roles of the logged-in user in the Web Debug Toolbar -- bugfix for two roles#43000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
NicoHaase referenced this pull requestSep 13, 2021
…ug Toolbar (NicoHaase)This PR was merged into the 5.4 branch.Discussion----------Display the roles of the logged-in user in the Web Debug Toolbar| Q | A| ------------- | ---| Branch? | 5.4 for features| Bug fix? | no| New feature? | yes| Deprecations? | yes/no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets |Fix#42763| License | MIT| Doc PR | -This PR adds the roles of the logged-in user to the WDTCommits-------1460732 Display the roles of the logged-in user in the Web Debug Toolbar
wouterj approved these changesSep 13, 2021
derrabus approved these changesSep 13, 2021
Member
derrabus commentedSep 13, 2021
Good catch, thanks@NicoHaase. |
ContributorAuthor
NicoHaase commentedSep 13, 2021
@mcorteel-harel spotted this bug this morning - I haven't found it myself |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit from#42800 did not work properly if there are exactly two roles assigned to the logged in user (as then, the first would be shown, but not the "and n more" span). This PR fixes this issue