Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DependencyInjection] Make auto-aliases private by default#42959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
1c8c9f3 toe7fc27fComparecarsonbot commentedSep 10, 2021
Hey! I think@fancyweb has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
derrabus approved these changesSep 10, 2021
e7fc27f to1f3c1f7Compare1f3c1f7 to679f25eCompareMemberAuthor
nicolas-grekas commentedSep 10, 2021
The remaining deprecation should be fixed by#42979 |
nicolas-grekas added a commit that referenced this pull requestSep 10, 2021
…deprecation (nicolas-grekas)This PR was merged into the 5.3 branch.Discussion----------[FrameworkBundle] fix session-related BC layer triggering deprecation| Q | A| ------------- | ---| Branch? | 5.3| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -Needed to make ##42959 green.Commits-------18ab810 [FrameworkBundle] fix session-related BC layer triggering deprecation
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces#41209
Before, this creates a public autoalias:
After, this creates a public autoalias:
Omitting
public: truewill trigger a deprecation warning when the alias is accessed from$container->get(). In 6.0, the alias will be private by default ifpublic: trueis not set.