Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[RateLimiter][Runtime][Translation] remove@experimental flag#42957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
wouterj commentedSep 10, 2021
That sentence ("Once the authenticator system is no longer experimental, this class can be used to trigger deprecation notices.") can be removed. We decided not to add a deprecation notice there, as it was already covered by other deprecation notices about the old authentication system. |
nicolas-grekas commentedSep 10, 2021
Thanks for the hint. PR is ready. |
OskarStark left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you!
…d (Jean-Beru)This PR was merged into the 5.4 branch.Discussion----------[RateLimiter][Runtime] Remove experimental from README.md| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | no| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets | <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->| License | MIT| Doc PR | <!-- required for new features -->Since#42957 is merged, experimental mentions in RateLimiter and Runtime README.md files can be removed.Commits-------012d328 [RateLimiter][Runtime] Remove experimental from README.md
…d (Jean-Beru)This PR was merged into the 5.4 branch.Discussion----------[RateLimiter][Runtime] Remove experimental from README.md| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | no| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets | <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->| License | MIT| Doc PR | <!-- required for new features -->Sincesymfony/symfony#42957 is merged, experimental mentions in RateLimiter and Runtime README.md files can be removed.Commits-------012d3286d2 [RateLimiter][Runtime] Remove experimental from README.md
…d (Jean-Beru)This PR was merged into the 5.4 branch.Discussion----------[RateLimiter][Runtime] Remove experimental from README.md| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | no| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets | <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->| License | MIT| Doc PR | <!-- required for new features -->Sincesymfony/symfony#42957 is merged, experimental mentions in RateLimiter and Runtime README.md files can be removed.Commits-------012d3286d2 [RateLimiter][Runtime] Remove experimental from README.md
Uh oh!
There was an error while loading.Please reload this page.
/cc@wouterj there is a note in
src/Symfony/Component/Security/Http/Authentication/NoopAuthenticationManager.phpthat some cleanup is needed now, can you please have a look?