Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Implement Message Stream for Postmark Mailer#42941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4fromdriesvints:postmark-stream-header
Sep 10, 2021
Merged

Implement Message Stream for Postmark Mailer#42941

fabpot merged 1 commit intosymfony:5.4fromdriesvints:postmark-stream-header
Sep 10, 2021

Conversation

@driesvints
Copy link
Contributor

@driesvintsdriesvints commentedSep 8, 2021•
edited
Loading

QA
Branch?5.4
Bug fix?no
New feature?yes (I did not find a changelog for 5.4)
Deprecations?no
Tickets
LicenseMIT
Doc PRThere doesn't appear to be a Postmark section in the docs right now

This PR provide's support for Postmark's separate Message Stream feature in both the API and SMTP transports. I've added the ability to both add a default Message Stream for the entire transport as well as specific message streams per email.

Right now in Laravel users have the ability to define a default Message Stream per transport through the wildbit/swiftmailer-postmark package. But unfortunately Symfony Mailer, which we're switching to for the upcoming Laravel v9 release doesn't has this feature yet. That's why we decided to send in this PR so both Symfony and Laravel users can enjoy this feature from Postmark. This PR is needed forlaravel/framework#38481

I've added a newMessageStreamHeader specifically for Postmark because it's a Postmark specific feature.

Documentation for SMTP can be found here:https://postmarkapp.com/support/article/1207-how-to-create-and-send-through-message-streams
Documentation for API can be found here:https://postmarkapp.com/developer/api/email-api

Current setup through Laravel can be found here:https://laravel.com/docs/8.x/mail#postmark-driver
Another example is Mailcoach by Spatie:https://spatie.be/docs/laravel-mailcoach/v4/configuring-mail-providers/postmark#setting-the-message-stream-in-your-laravel-app

@carsonbot
Copy link

Hey!

To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done?

Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review.

Cheers!

Carsonbot

@driesvints
Copy link
ContributorAuthor

There seem to be some code style issues but fabbot.io doesn't say what they are.

@driesvints
Copy link
ContributorAuthor

I accidentally set "deprecations" to yes instead of no so carsonbot marked this PR as such, sorry.

@javiereguiluz
Copy link
Member

Dries, we removed thedeprecation label. Thanks for telling us.

driesvints reacted with thumbs up emoji

@driesvintsdriesvints changed the titleImplement Message Stream for Postmark Mailer[Mailer] Implement Message Stream for Postmark MailerSep 8, 2021
@Jubeki
Copy link
Contributor

Screenshot 2021-09-08 at 17 36 50

@driesvints You can click onPreview to see the needed changes.

@driesvints
Copy link
ContributorAuthor

I don't see a Preview button.

@Jubeki
Copy link
Contributor

Screenshot 2021-09-08 at 17 48 43

It seems like I can't read it saysReview

@driesvints
Copy link
ContributorAuthor

@Jubeki ah wow, totally missed that. I was clicking the red "3" all the time 😅

Thanks, got those fixed

Jubeki reacted with laugh emoji

@nicolas-grekasnicolas-grekas added this to the5.4 milestoneSep 9, 2021
@driesvints
Copy link
ContributorAuthor

Unsure why the AppVeyor build is failing. I can't see any failing tests but it's a little hard to digest with all the separate runs for the different components.

@andrew-demb
Copy link
Contributor

@driesvints as I can see, this is related to maximum build time exceeded (20 minutes) -https://ci.appveyor.com/project/fabpot/symfony/builds/40692324/messages

I think this fail should be skipped

driesvints reacted with thumbs up emoji

@carsonbotcarsonbot changed the title[Mailer] Implement Message Stream for Postmark MailerImplement Message Stream for Postmark MailerSep 9, 2021
@fabpot
Copy link
Member

Thank you@driesvints.

driesvints, Jubeki, xtrasmal, jonnott, and kemp reacted with hooray emoji

@fabpotfabpot merged commitaf5216c intosymfony:5.4Sep 10, 2021
@driesvintsdriesvints deleted the postmark-stream-header branchSeptember 10, 2021 08:19
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

@fabpotfabpotAwaiting requested review from fabpot

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

8 participants

@driesvints@carsonbot@javiereguiluz@Jubeki@andrew-demb@fabpot@nicolas-grekas@OskarStark
[8]ページ先頭
©2009-2025 Movatter.jp