Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Messenger] Support rediss in transport bridge#42932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@RuslanZavacky
Copy link
Contributor

@RuslanZavackyRuslanZavacky commentedSep 8, 2021
edited by nicolas-grekas
Loading

QA
Branch?5.3
Bug fix?yes
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR

Seems like support forrediss was added in themain package, but didn't propagate to the bridge

Followed a trail from here -#39607

oleg-andreyev reacted with thumbs up emoji
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@RuslanZavacky
Copy link
ContributorAuthor

Feels like I might've opened it to the wrong initial branch, probably the lowest should be as 5.3, if that's the case, let me know and I can redo this one :)

@RuslanZavacky
Copy link
ContributorAuthor

Test failure doesn't seem to be relevant, or I am missing something?

@carsonbotcarsonbot changed the titleSupport rediss in transport bridge[Messenger] Support rediss in transport bridgeSep 8, 2021
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(for 5.3)

@nicolas-grekasnicolas-grekas changed the base branch from5.4 to5.3September 8, 2021 16:56
@nicolas-grekasnicolas-grekasforce-pushed thesupport-rediss-in-transport-bridge branch fromce7dceb toedfad64CompareSeptember 8, 2021 16:56
@nicolas-grekas
Copy link
Member

Thank you@RuslanZavacky.

RuslanZavacky reacted with thumbs up emoji

@nicolas-grekasnicolas-grekas merged commit3cf8234 intosymfony:5.3Sep 8, 2021
@fabpotfabpot mentioned this pull requestSep 28, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@srozesrozeAwaiting requested review from sroze

@chalasrchalasrAwaiting requested review from chalasr

@dunglasdunglasAwaiting requested review from dunglas

@jderussejderusseAwaiting requested review from jderusse

@lyrixxlyrixxAwaiting requested review from lyrixx

@OskarStarkOskarStarkAwaiting requested review from OskarStark

@wouterjwouterjAwaiting requested review from wouterj

@xabbuhxabbuhAwaiting requested review from xabbuh

@ycerutoycerutoAwaiting requested review from yceruto

Assignees

No one assigned

Projects

None yet

Milestone

5.3

Development

Successfully merging this pull request may close these issues.

3 participants

@RuslanZavacky@carsonbot@nicolas-grekas

[8]ページ先頭

©2009-2025 Movatter.jp