Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Messenger] Support rediss in transport bridge#42932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Messenger] Support rediss in transport bridge#42932
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedSep 8, 2021
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
RuslanZavacky commentedSep 8, 2021
Feels like I might've opened it to the wrong initial branch, probably the lowest should be as 5.3, if that's the case, let me know and I can redo this one :) |
RuslanZavacky commentedSep 8, 2021
Test failure doesn't seem to be relevant, or I am missing something? |
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
(for 5.3)
ce7dceb toedfad64Comparenicolas-grekas commentedSep 8, 2021
Thank you@RuslanZavacky. |
Uh oh!
There was an error while loading.Please reload this page.
Seems like support for
redisswas added in themain package, but didn't propagate to the bridgeFollowed a trail from here -#39607