Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Cache] Make sure PdoAdapter::prune() always returns a bool#42904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@derrabus
Copy link
Member

@derrabusderrabus commentedSep 6, 2021•
edited
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsN/A
LicenseMIT
Doc PRN/A

This fixes a failing test on the 6.0 branch.I wasn't sure if I should backport this change to 4.4/5.3 since the behavior of returning a DBAL result has always been wrong, kinda. Backported!

@nicolas-grekas
Copy link
Member

I think this should be fine for 4.4

@nicolas-grekasnicolas-grekas added this to the4.4 milestoneSep 6, 2021
@fabpot
Copy link
Member

Can you rebase on 4.4 then?

derrabus reacted with thumbs up emoji

@derrabusderrabusforce-pushed thebugfix/pdo-adapter-return-type branch from8b3a1df toabad7cfCompareSeptember 7, 2021 06:54
@derrabusderrabus changed the base branch from5.4 to4.4September 7, 2021 06:54
@derrabusderrabus reopened thisSep 7, 2021
Signed-off-by: Alexander M. Turek <me@derrabus.de>
@derrabusderrabusforce-pushed thebugfix/pdo-adapter-return-type branch fromabad7cf tob8ddb65CompareSeptember 7, 2021 06:55
@derrabus
Copy link
MemberAuthor

Done! I've also adjustedAdapterTestCase to check the return value ofprune() calls.

@nicolas-grekas
Copy link
Member

Thank you@derrabus.

@nicolas-grekasnicolas-grekas merged commitba46a07 intosymfony:4.4Sep 7, 2021
@derrabusderrabus deleted the bugfix/pdo-adapter-return-type branchSeptember 7, 2021 07:29
This was referencedSep 28, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

4 participants

@derrabus@nicolas-grekas@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp