Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Console] Add more context when CommandIsSuccessful fails#42881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@yoannrenard
Copy link
Contributor

QA
Branch?5.4
Bug fix?no
New feature?no
Deprecations?no
TicketsN/A
LicenseMIT
Doc PRN/A

Give some more context when CommandIsSuccessful::assertCommandIsSuccessful() fails

$this->assertFalse($constraint->evaluate(Command::INVALID,'',true));
}

publicfunctionprovidesUnsuccessful():iterable

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

please put the dataprovider after the test case

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Done

@fabpotfabpotforce-pushed theadd_more_context_CommandIsSuccessful branch from41178ca to695cd9dCompareSeptember 7, 2021 11:19
@fabpot
Copy link
Member

Thank you@yoannrenard.

@fabpotfabpot merged commitc4df3a7 intosymfony:5.4Sep 7, 2021
@yoannrenardyoannrenard deleted the add_more_context_CommandIsSuccessful branchSeptember 7, 2021 11:38
This was referencedNov 5, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

4 participants

@yoannrenard@fabpot@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp