Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Cache] Fix implicit float to int cast#42835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.4fromderrabus:bugfix/cache-float-cast
Sep 3, 2021

Conversation

@derrabus
Copy link
Member

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsPart of#41552
LicenseMIT
Doc PRN/A

Passing a float to a method that expects an integer triggers a deprecation on PHP 8.1 if that implicit float to int cast would mean a loss of precision. This PR fixes such an error in the cache component by making sure an integer is passed. This fixes an error in our 5.3 CI.

@fabpot
Copy link
Member

Thank you@derrabus.

@fabpotfabpot merged commit1e2bf5d intosymfony:4.4Sep 3, 2021
This was referencedSep 28, 2021
@derrabusderrabus deleted the bugfix/cache-float-cast branchDecember 3, 2021 22:50
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

+1 more reviewer

@TobionTobionTobion approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

5 participants

@derrabus@fabpot@Tobion@OskarStark@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp