Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Mime] Update mime types#42831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
derrabus merged 1 commit intosymfony:4.4fromfabpot:mime-types-update
Sep 2, 2021
Merged

Conversation

@fabpot
Copy link
Member

QA
Branch?4.4
Bug fix?no
New feature?no
Deprecations?no
Ticketsn/a
LicenseMIT
Doc PRsymfony/symfony-docs#...

@derrabus
Copy link
Member

Thank you Fabien.

@derrabusderrabus merged commitcac85b3 intosymfony:4.4Sep 2, 2021
@derrabus
Copy link
Member

@fabpot Apparently, the list of MIME types has been changed on 5.3 in the past and I'm a bit clueless how to merge your changes to 4.4 up to 5.3. Can you please have a look?

@nicolas-grekas
Copy link
Member

Shouldn't we merge such changes in 5.4?

@fabpotfabpot deleted the mime-types-update branchSeptember 3, 2021 07:32
@fabpot
Copy link
MemberAuthor

Arf, I've been caught at my own game. I'm the one advocating more merges in the main branch, and I've submitted this one on 4.4. My bad. I will revert on 4.4 and submit one on 5.4 instead.

derrabus reacted with thumbs up emojinicolas-grekas and lynnntropy reacted with laugh emoji

fabpot added a commit that referenced this pull requestSep 3, 2021
This reverts commitcac85b3, reversingchanges made toced4415.
fabpot added a commit that referenced this pull requestSep 3, 2021
* 4.4:  Revert "bug#42831 [Mime] Update mime types (fabpot)"  Fix implicit float to int cast  [Mime] Update mime types  [HttpKernel] Fix timeline in profiler
fabpot added a commit that referenced this pull requestSep 3, 2021
* 5.3:  Revert "bug#42831 [Mime] Update mime types (fabpot)"  Clean about command description after Environment section was removed  Fix implicit float to int cast  [Mime] Update mime types  [HttpKernel] Fix timeline in profiler
@fabpot
Copy link
MemberAuthor

See#42872

derrabus added a commit that referenced this pull requestSep 3, 2021
* 5.4:  Revert "bug#42831 [Mime] Update mime types (fabpot)"  Clean about command description after Environment section was removed  Fix implicit float to int cast  [Mime] Update mime types  [HttpKernel] Fix timeline in profiler
This was referencedSep 28, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof left review comments

@OskarStarkOskarStarkOskarStark approved these changes

@derrabusderrabusderrabus approved these changes

+1 more reviewer

@ro0NLro0NLro0NL left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

7 participants

@fabpot@derrabus@nicolas-grekas@stof@OskarStark@ro0NL@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp