Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpKernel] FixTimeDataCollector#42823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
TimeDataCollectorIn order for the `TimeDataCollector` to work properly the `X-Debug-Token` from the response header needs to be used which was removed insymfony#42331 tofixsymfony#36623.Fixessymfony#42804
7fc5712 todb1a9c2Compareherndlm commentedSep 1, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The goal here was to be compatible with the previous behaviour but another simpler solution is at#42830 |
herndlm commentedSep 1, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
With the changes being only in one component there is no need for keeping the header token check I guess. The simpler fix is definitely the better one than! |
This PR was merged into the 4.4 branch.Discussion----------[HttpKernel] Fix empty timeline in profilerSimple fix to#42804| Q | A| ------------- | ---| Branch? | 5.3 && 4.4| Bug fix? | yes| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets |Fix#42804 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->| License | MITFix#42804 following#42331 conventionsAnother solution could be found here#42823<!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/releases): - Always add tests and ensure they pass. - Never break backward compatibility (seehttps://symfony.com/bc). - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too.) - Features and deprecations must be submitted against branch 5.x. - Changelog entry should followhttps://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry-->Commits-------f1b3840 [HttpKernel] Fix timeline in profiler
Uh oh!
There was an error while loading.Please reload this page.
In order for the
TimeDataCollectorto work properly theX-Debug-Tokenfrom the response header needs to be used which was removed in#42331 tofix#36623.Fixes#42804In order for the TimeDataCollector to work properly the X-Debug-Token from the response header needs to be used which was removed in#42331 tofix#36623.
Manually tested via profiler in a new app and via disabled profiler and command mentioned in#36623 (comment). I'm not a 100% sure if this is the best fix though.