Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix tests failing with DBAL 3#42819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.4fromderrabus:bugfix/doctrine-tests
Sep 1, 2021

Conversation

@derrabus
Copy link
Member

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsN/A
LicenseMIT
Doc PRN/A

Doctrine ORM is not blocking the installation of DBAL 3 anymore. This has revealed a few tests that were not fully compatible with DBAL 3. This PR is an attempt to fix them.

@derrabus
Copy link
MemberAuthor

I'd prefer to ignore fabbot's suggestion if that's okay.

@derrabusderrabus mentioned this pull requestAug 31, 2021
$stmt =$this->getConnection()->prepare($sql);
$stmt->bindValue($i =1,$now, \PDO::PARAM_INT);
$stmt =$connection->prepare($sql);
$stmt->bindValue($i =1,$now,$useDbalConstants ? ParameterType::INTEGER :\PDO::PARAM_INT);
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Using the PDO constants on a DBAL 3 connection will break in PHP 8.1 because PDO changed the values of those constants. 😱

@derrabusderrabusforce-pushed thebugfix/doctrine-tests branch 2 times, most recently from23f9649 to784d948CompareSeptember 1, 2021 10:43
@fabpot
Copy link
Member

Thank you@derrabus.

@fabpotfabpot merged commit1b496a0 intosymfony:4.4Sep 1, 2021
@derrabusderrabus deleted the bugfix/doctrine-tests branchSeptember 1, 2021 12:56
This was referencedSep 28, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof left review comments

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

@srozesrozeAwaiting requested review from sroze

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

@wouterjwouterjAwaiting requested review from wouterjwouterj is a code owner

+1 more reviewer

@TobionTobionTobion left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

6 participants

@derrabus@fabpot@stof@Tobion@OskarStark@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp